Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yeti defaults: Remove license URL to avoid issues with existing studio envs #5

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Yeti defaults: Remove license URL to avoid issues with existing studio envs #5

merged 2 commits into from
Jul 17, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 17, 2024 •
edited
Loading

Yeti defaults: Remove license URL to avoid issues with existing studio envs

MustafaJafar
MustafaJafar approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

@BigRoy
Remove the license example completely to avoid the example even overw…
ea395bd 
…riting anything studio specific potentially already present
@BigRoy BigRoy changed the title Yeti defaults: Provide more 'examplary' to clarify it's an example value Yeti defaults: Remove license URL to avoid issues with existing studio envs Jul 17, 2024
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@BigRoy BigRoy merged commit 307e074 into develop Jul 17, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/remove_invalid_license_uri_example branch July 17, 2024 13:32
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@MustafaJafar MustafaJafar MustafaJafar approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees
No one assigned
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BigRoy @m-u-r-p-h-y @MustafaJafar @iLLiCiTiT