Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ocio_config ImageIOConfigModel settings #11

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 17, 2024

Changelog Description

Remove deprecated ocio_config ImageIOConfigModel settings

Additional info

With the support of profiles to determine OCIO config in ayon-core this logic has been superseded and should be removed from each addon still having the deprecated settings.

@BigRoy BigRoy requested a review from iLLiCiTiT July 17, 2024 18:47
@BigRoy BigRoy self-assigned this Jul 17, 2024
@BigRoy BigRoy marked this pull request as ready for review July 18, 2024 10:14
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't defaults also be removed?

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no defaults are actually present then this is good to be merged

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 19, 2024

@iLLiCiTiT thanks for fixing :) saves me some time.

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 19, 2024

Ready to merge.

@BigRoy BigRoy assigned iLLiCiTiT and unassigned BigRoy Jul 19, 2024
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jul 19, 2024

@iLLiCiTiT thanks for fixing :) saves me some time.

It contains more commits than should, so I didn't fix it properly...

EDITED: Now it looks correct.

@iLLiCiTiT iLLiCiTiT force-pushed the chore/remove_deprecated_imageioconfig branch from b7721f4 to 4e1f960 Compare July 19, 2024 10:46
@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 19, 2024

It's a thing of beauty @iLLiCiTiT ❤️

@BigRoy BigRoy merged commit 3ae4f01 into ynput:develop Jul 22, 2024
1 check passed
@BigRoy BigRoy deleted the chore/remove_deprecated_imageioconfig branch July 22, 2024 11:55
@iLLiCiTiT iLLiCiTiT assigned BigRoy and unassigned iLLiCiTiT Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants