Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch asset support for all loaders inheriting from BlenderLoader #43

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 17, 2024

Changelog Description

Adds support for "Switch Asset" in scene inventory for blender loaders.

Additional info

Based on comment here

Testing notes:

  1. Validate the 'switch' works as intended for managed Blender loaders

@BigRoy BigRoy added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Sep 17, 2024
@BigRoy BigRoy self-assigned this Sep 17, 2024
@BigRoy BigRoy mentioned this pull request Sep 18, 2024
6 tasks
@moonyuet
Copy link
Member

moonyuet commented Sep 19, 2024

When I tries to do switch version from the same product type(in my case "model"), some errors pop up.
image
Making me wonder if we should introduce the switch version in blender, as it somehow involves different modifiers during updating/setting version

@LiborBatek
Copy link
Member

@moonyuet are u refering more to a Set Version as there is a Switch Folder not Version ...as Im experiencing issues with the Set Version atm in latest release of ayon-blender addon too

@moonyuet
Copy link
Member

@moonyuet are u refering more to a Set Version as there is a Switch Folder not Version ...as Im experiencing issues with the Set Version atm in latest release of ayon-blender addon too

I am more referring to the switch folder here but this is also related to set version in blender.

@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 19, 2024

@moonyuet I think you're facing this issue #40 - and hence it's not due to this PR. If pointcache updating is currently broken - then you're best off trying other product types for this PR.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well...been tested on rig model and blendScene all working nicely!

B3d_switch_asset

@BigRoy BigRoy merged commit 365dd33 into ynput:develop Sep 24, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/add_default_switch_support branch September 24, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants