Skip to content

Commit

Permalink
AY-7222 Fix otio_review no handles and tempdir for Resolve
Browse files Browse the repository at this point in the history
  • Loading branch information
robin-ynput committed Dec 9, 2024
1 parent ccd1854 commit 49d1515
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
13 changes: 13 additions & 0 deletions client/ayon_core/pipeline/tempdir.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import os
import tempfile
from pathlib import Path
import warnings

from ayon_core.lib import StringTemplate
from ayon_core.pipeline import Anatomy
Expand Down Expand Up @@ -70,6 +71,18 @@ def _create_local_staging_dir(prefix, suffix, dirpath=None):
)


def create_custom_tempdir(project_name, anatomy):
""" Deprecated 09/12/2024, here for backward-compatibility with Resolve.
"""
warnings.warn(
"Used deprecated 'create_custom_tempdir' "
"use 'ayon_core.pipeline.tempdir.get_temp_dir' instead.",
DeprecationWarning,
)

return _create_custom_tempdir(project_name, anatomy)


def _create_custom_tempdir(project_name, anatomy):
""" Create custom tempdir
Expand Down
7 changes: 4 additions & 3 deletions client/ayon_core/plugins/publish/extract_otio_review.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,16 @@ def process(self, instance):
# TODO: convert resulting image sequence to mp4

# get otio clip and other time info from instance clip
# TODO: what if handles are different in `versionData`?
handle_start = instance.data["handleStart"]
handle_end = instance.data["handleEnd"]
otio_review_clips = instance.data.get("otioReviewClips")

if otio_review_clips is None:
self.log.info(f"Instance `{instance}` has no otioReviewClips")
return

# TODO: what if handles are different in `versionData`?
handle_start = instance.data["handleStart"]
handle_end = instance.data["handleEnd"]

# add plugin wide attributes
self.representation_files = []
self.used_frames = []
Expand Down

0 comments on commit 49d1515

Please sign in to comment.