Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Stricter ruff config #1022

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Chore: Stricter ruff config #1022

merged 4 commits into from
Nov 25, 2024
+165 −98

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Ruff config is now stricter and reports all linting errors.

Additional info

Fixed/modified all places that were reported by ruff.

Testing notes:

  1. Look at code changes.
  2. Verify code changes.

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 25, 2024
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Nov 25, 2024
@ynbot ynbot added the size/S label Nov 25, 2024
robin-ynput
robin-ynput approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@robin-ynput robin-ynput left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly tested it locally and went through the files, as far I as can this it's all cosmetics changes dictated by ruff new rule set. LGTM.

@iLLiCiTiT iLLiCiTiT merged commit ce614a4 into develop Nov 25, 2024
9 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/strticter-ruff-config branch November 25, 2024 13:49
@antirotor
Copy link
Member

Not strict enough, but it is good start! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-ynput robin-ynput robin-ynput approved these changes

@BigRoy BigRoy Awaiting requested review from BigRoy

@antirotor antirotor Awaiting requested review from antirotor

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iLLiCiTiT @antirotor @robin-ynput @ynbot