Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit order of instance creation and definition #1025

Open
12 tasks
iLLiCiTiT opened this issue Nov 25, 2024 · 0 comments
Open
12 tasks

Limit order of instance creation and definition #1025

iLLiCiTiT opened this issue Nov 25, 2024 · 0 comments
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Nov 25, 2024

Please describe the feature you have in mind and explain what the current shortcomings are?

We have to define limit up to which point it is possible to create or change context (folder, task, product type/name) of instances during publishing.

I've already created multiple issue related to this task in related repositories that do recommend to use order CollectorsOrder - 0.2 as last possible limit. We should focus to do it earlier (as soon as possible). That will unblock a lot of global plugins to run earlier and will avoid having plugins with order CollectorsOrder + 0.499999999 because is dependent on something else etc.

This is a long run issue.

Relevant issues

If I missed any integration then please create an issue, or modify existing.

How would you imagine the implementation of the feature?

Define the limit, use the limit in Publisher code to validate it, and possibly report the issue with warning in console (or other way), so developers can actually have a way how to validate if it happens or not (even I don't know where/when I do create instances or change it's context).

When we tackle most of the logic changes we can slowly change order of global plugins like CollectInstanceAnatomyData earlier to validate if it really works.

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

1 participant