Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher actions are not registered or shown at all #1055

Open
2 tasks done
BigRoy opened this issue Dec 15, 2024 · 1 comment
Open
2 tasks done

Launcher actions are not registered or shown at all #1055

BigRoy opened this issue Dec 15, 2024 · 1 comment
Labels
type: bug Something isn't working

Comments

@BigRoy
Copy link
Collaborator

BigRoy commented Dec 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

With the latest ayon-core release it seems that both launcher actions inside ayon-core and external addons are not registered anymore. At least, they do not display in the Launcher anymore.

It's since this PR which removed this logic:

from ayon_core.pipeline.actions import register_launcher_action_path
actions_dir = os.path.join(AYON_CORE_ROOT, "plugins", "actions")
if os.path.exists(actions_dir):
register_launcher_action_path(actions_dir)
actions_paths = self.manager.collect_plugin_paths()["actions"]
for path in actions_paths:
if path and os.path.exists(path):
register_launcher_action_path(path)

Expected Behavior:

I wonder if the registering of them is lacking here or whether something else breaks it.

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

  1. Use latest ayon-core
  2. Launch launcher
  3. Show in AYON and Open In Explorer action do not show
  4. Similarly launcher actions from other addons also do not show

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

Additional context:

Also reported on discord here.

@BigRoy BigRoy added the type: bug Something isn't working label Dec 15, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Dec 15, 2024

I wonder if the registering of them is lacking here or whether something else breaks it.

Adding it there doesn't seem to register them in the launcher; likely that code is host install specific.
The question them becomes - where should the tray launcher actions registry occur now.

Might be best for @iLLiCiTiT to point at the best place to register them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant