Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix on getting aov expected files when global aov mode disabled in Redshift #178

Merged
merged 10 commits into from
Apr 5, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Mar 13, 2024

Changelog Description

This PR is to fix the bug on getting AOV render products as expected files when global aov mode is turned off in Redshift renderer

Additional info

Wait for the merge #173 and #184 before testing

Testing notes:

  1. Launch Maya via AYON
  2. Create Render Instance with Redshift as current renderer
  3. Disabled global aov mode
    image
  4. Publish

@moonyuet moonyuet requested a review from BigRoy April 2, 2024 14:23
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the functionality - but code makes sense. On to @LiborBatek for testing.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run this test, first adding some AOVs for render aka enabling those...

Cryptomatte
Z
N

Run Validate action via Publisher so I have proper AOVs naming via Repair action so validations goes well.

Then cancel the publishing and finally Disable Aovs via that RS option we are refering to in this PR.

After submitting it to DL my job fails on Publish Job due to expected Cryptomatte aov...

image

obviously when inspecting my JSON, it still expect those files...

So my question is, does this PR solves this scenario too? Speaking of Cryptomattes as optional AOVs with Global AOVs switch Disabled...

Right now it does not solve this issue.

@LiborBatek
Copy link
Member

Im enclosing the JSON for rendered frames and scrn grab of the error from DL log console... just as additional info for you

renderLightingMain_metadata.json.txt

Screenshot 2024-04-04 152300

@moonyuet
Copy link
Member Author

moonyuet commented Apr 4, 2024

Im enclosing the JSON for rendered frames and scrn grab of the error from DL log console... just as additional info for you

renderLightingMain_metadata.json.txt

Screenshot 2024-04-04 152300

Which means by this case we need to also exclude the cryptomatte.

@BigRoy
Copy link
Collaborator

BigRoy commented Apr 4, 2024

Im enclosing the JSON for rendered frames and scrn grab of the error from DL log console... just as additional info for you
renderLightingMain_metadata.json.txt
Screenshot 2024-04-04 152300

Which means by this case we need to also exclude the cryptomatte.

But.. doesn't this code already exclude that? It excludes all AOVs - also the Cryptomattes, right?

@moonyuet
Copy link
Member Author

moonyuet commented Apr 4, 2024

Im enclosing the JSON for rendered frames and scrn grab of the error from DL log console... just as additional info for you
renderLightingMain_metadata.json.txt
Screenshot 2024-04-04 152300

Which means by this case we need to also exclude the cryptomatte.

But.. doesn't this code already exclude that? It excludes all AOVs - also the Cryptomattes, right?

for some reason, it doesn't work in my side too. It can be the merged PR from the renderlayer-related changes.

@moonyuet moonyuet requested review from LiborBatek and BigRoy April 4, 2024 15:16
client/ayon_core/hosts/maya/api/lib.py Show resolved Hide resolved
client/ayon_core/hosts/maya/api/lib.py Show resolved Hide resolved
client/ayon_core/hosts/maya/api/lib.py Outdated Show resolved Hide resolved
@moonyuet moonyuet requested a review from BigRoy April 5, 2024 07:10
@LiborBatek
Copy link
Member

@BigRoy @moonyuet could be that RS always keep Cryptomatte as separate files always? (to my surprise, as Arnold dont do that by nature when multilayer exr enabled)

@moonyuet
Copy link
Member Author

moonyuet commented Apr 5, 2024

@BigRoy @moonyuet could be that RS always keep Cryptomatte as separate files always? (to my surprise, as Arnold dont do that by nature when multilayer exr enabled)

If AOV mode is globally turned off, Redshift won't render Cryptomatte no matter what. It's just beauty rendering out.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working now without any errors shown... there werent other files expected besides the renderLightingMain one, so all good.

My job successfully finished on DL.

image

Note: For some reason my rendered frames when integrated didnt produce any reviewable mp4 and thumbnail. Is it related to this PR or not? For this reason, Im enclosing DL publish job LOG too

Job_2024-04-05_09-48-47_660facdfc97c3c722d19f16d.txt

@moonyuet
Copy link
Member Author

moonyuet commented Apr 5, 2024

@BigRoy if you are happy with it, we can merge this PR.

@moonyuet moonyuet merged commit 8fdd804 into develop Apr 5, 2024
1 check failed
@moonyuet moonyuet deleted the bugfix/AY-3433_Maya-redshift-AOV-mode branch April 5, 2024 08:13
@moonyuet
Copy link
Member Author

moonyuet commented Apr 5, 2024

All working now without any errors shown... there werent other files expected besides the renderLightingMain one, so all good.

My job successfully finished on DL.

image

Note: For some reason my rendered frames when integrated didnt produce any reviewable mp4 and thumbnail. Is it related to this PR or not? For this reason, Im enclosing DL publish job LOG too

Job_2024-04-05_09-48-47_660facdfc97c3c722d19f16d.txt

I dont think it is related to this PR as this PR is just about redshift aov being enabled globally in maya host.
This is more likely about submit publish job have encountered some issues. Can you try with different renderers to see the issue still exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya size/S type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants