-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix on getting aov expected files when global aov mode disabled in Redshift #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test the functionality - but code makes sense. On to @LiborBatek for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run this test, first adding some AOVs for render aka enabling those...
Cryptomatte
Z
N
Run Validate action via Publisher so I have proper AOVs naming via Repair
action so validations goes well.
Then cancel the publishing and finally Disable Aovs
via that RS option we are refering to in this PR.
After submitting it to DL my job fails on Publish Job
due to expected Cryptomatte
aov...
obviously when inspecting my JSON, it still expect those files...
So my question is, does this PR solves this scenario too? Speaking of Cryptomattes as optional AOVs with Global AOVs switch Disabled...
Right now it does not solve this issue.
Im enclosing the JSON for rendered frames and scrn grab of the error from DL log console... just as additional info for you renderLightingMain_metadata.json.txt |
Which means by this case we need to also exclude the cryptomatte. |
But.. doesn't this code already exclude that? It excludes all AOVs - also the Cryptomattes, right? |
for some reason, it doesn't work in my side too. It can be the merged PR from the renderlayer-related changes. |
…& renderlayersetup
…string value as before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working now without any errors shown... there werent other files expected besides the renderLightingMain
one, so all good.
My job successfully finished on DL.
Note: For some reason my rendered frames when integrated didnt produce any reviewable mp4
and thumbnail
. Is it related to this PR or not? For this reason, Im enclosing DL publish job LOG too
@BigRoy if you are happy with it, we can merge this PR. |
I dont think it is related to this PR as this PR is just about redshift aov being enabled globally in maya host. |
Changelog Description
This PR is to fix the bug on getting AOV render products as expected files when global aov mode is turned off in Redshift renderer
Additional info
Wait for the merge #173 and #184 before testing
Testing notes: