Publisher: handling of exceptions on publish

[antirotor]

Is there an existing issue for this?

• I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Whenever you hit publish or validate buttons and something happens in underlaying host code (some exception happens) , there might not be any feedback at all, except the fact that the publishing never started.

How would you imagine the implementation of the feature?

We should probably catch exception somewhere here:

ayon-core/client/ayon_core/tools/publisher/window.py

Lines 824 to 846 in d759c9b

	def _on_publish_clicked(self):
	if self._save_changes(False):
	self._set_publish_comment()
	self._controller.publish()
	def _set_footer_enabled(self, enabled):
	self._save_btn.setEnabled(True)
	self._reset_btn.setEnabled(True)
	if enabled:
	self._stop_btn.setEnabled(False)
	self._validate_btn.setEnabled(True)
	self._publish_btn.setEnabled(True)
	else:
	self._stop_btn.setEnabled(enabled)
	self._validate_btn.setEnabled(enabled)
	self._publish_btn.setEnabled(enabled)
	def _on_publish_reset(self):
	self._create_tab.setEnabled(True)
	self._set_comment_input_visiblity(True)
	self._set_publish_overlay_visibility(False)
	self._set_publish_visibility(False)
	self._update_publish_details_widget()

and perhaps display the exception itself using QtWidgets.QMessageBox.critical() or similar.

Are there any labels you wish to add?

• I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

[BigRoy]

This would be very nice with a reproducable example actually. Any idea how to get that to fail?

[antirotor]

This would be very nice with a reproducable example actually. Any idea how to get that to fail?

You can raise Exception in host.update_context_data() for example, that one is called before validate and publish.