Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant JOB_ENV_DATA_KEY should move out of ayon-deadline #43

Open
2 tasks done
BigRoy opened this issue Oct 8, 2024 · 2 comments
Open
2 tasks done

Constant JOB_ENV_DATA_KEY should move out of ayon-deadline #43

BigRoy opened this issue Oct 8, 2024 · 2 comments
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@BigRoy
Copy link
Contributor

BigRoy commented Oct 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

With #32 we added a JOB_ENV_DATA_KEY to start deduplicating the code. But this should start moving out of ayon-deadline into e.g. ayon-core as soon as we have the data structure defined nicely for separate jobs like render, export and publish jobs.

How would you imagine the implementation of the feature?

Make it a constant in ayon-core as soon as we have pinned down that this key is sufficient for re-use in other repos (and also other farm managers and submissions)

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

Related to ynput/ayon-core#876

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Oct 8, 2024
@iLLiCiTiT
Copy link
Member

PR https://github.com/ynput/ayon-core/pull/1023/files added FARM_JOB_ENV_DATA_KEY to ayon-core, now we can just use it and remove the JOB_ENV_DATA_KEY from deadline.

I didn't see it being used elsewhere so it should be safe.

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Dec 9, 2024

BTW created issues so other addons are filling the environment variable keys on their own:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

2 participants