Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register host-specific Deadline plugins only on install of the host #6

Merged
merged 11 commits into from
Jul 12, 2024
Merged

Register host-specific Deadline plugins only on install of the host #6

merged 11 commits into from
Jul 12, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 8, 2024 •
edited by kalisp
Loading

Changes

Move host-specific deadline plug-ins into host folders that are only registered on install of the host.

This way, e.g. the Maya Deadline plug-in is not registered when launching Houdini, Nuke, etc and vice versa.

Fixes #4

Testing notes

  1. Deadline publishing across all supported hosts should still work
  • after effects
  • blender
  • celaction
  • fusion
  • harmony
  • houdini
  • max
  • maya
  • nuke
  1. Rendering + publish jobs should still work
  2. Under the "Details" > "Crashed Plugins" no Deadline plug-ins should show up.

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Jul 8, 2024
@BigRoy BigRoy requested a review from iLLiCiTiT July 12, 2024 08:48
MustafaJafar
MustafaJafar approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool.
It works on my side in Houdini.

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 12, 2024

Some addons have been tested - others shouldn't be affected in a different way so I'd say this is safe to merge. @iLLiCiTiT

moonyuet
moonyuet approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Max.

@BigRoy @iLLiCiTiT
Refactor variable name
35fd981 
Co-authored-by: Jakub Trllo <[email protected]>
@BigRoy BigRoy requested a review from iLLiCiTiT July 12, 2024 10:33
@kalisp
Copy link
Member

kalisp commented Jul 12, 2024

Tested in AE, Maya (where it actually helps to clear Max imports)

@kalisp kalisp self-requested a review July 12, 2024 11:04
@iLLiCiTiT iLLiCiTiT merged commit 4f02e8b into ynput:develop Jul 12, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/register_host_specific_plugins branch July 19, 2024 10:05
tweak-wtf pushed a commit to tweak-wtf/ayon-deadline that referenced this pull request Dec 13, 2024
@AlSzab
Merge pull request 'feat/abc_sequential' (ynput#6) from feat/abc_sequ…
7c72e70 
…ential into develop

Reviewed-on: http://bepic-docker01:3090/ayon/ayon-deadline/pulls/6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@MustafaJafar MustafaJafar MustafaJafar approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: host specific Deadline plugins crashing outside their context
5 participants
@BigRoy @kalisp @MustafaJafar @iLLiCiTiT @moonyuet