Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusion: Fix submission of multiple fusion render instances #86

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Dec 11, 2024

Changelog Description

Fix submission of multiple fusion render instances in one go by also storing instance.data["deadline"] correctly to each instance

Additional review information

Fixes error:

Traceback (most recent call last):
  File "C:\Users\Maqina-RTX-05\AppData\Local\Ynput\AYON\dependency_packages\ayon_2407291312_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "C:\Users\Maqina-RTX-05\AppData\Local\Ynput\AYON\addons\deadline_0.5.1+cb.1\ayon_deadline\plugins\publish\global\submit_publish_job.py", line 418, in process
    representations = prepare_representations(
  File "C:\Users\Maqina-RTX-05\AppData\Local\Ynput\AYON\addons\core_1.0.10+cb.1\ayon_core\pipeline\farm\pyblish_functions.py", line 340, in prepare_representations
    frames_to_render = _get_real_frames_to_render(frames_to_render)
  File "C:\Users\Maqina-RTX-05\AppData\Local\Ynput\AYON\addons\core_1.0.10+cb.1\ayon_core\pipeline\farm\pyblish_functions.py", line 493, in _get_real_frames_to_render
    frames_to_render.append(int(frame))
ValueError: invalid literal for int() with base 10: ''

Testing notes:

  1. Create multiple render saver instances.
  2. Publish both at the same time via the farm.

…storing `instance.data["deadline"]` correctly to each instance
@BigRoy BigRoy added the type: bug Something isn't working label Dec 11, 2024
@BigRoy BigRoy requested a review from kalisp December 11, 2024 22:38
@BigRoy BigRoy self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant