AY-6975_Broken retiming calculation

[ynbot]

Please describe the issue you have encountered?

This might be effecting handles calculation but also clip length too. We need to investigate what can be improved withing the retiming calculations in general. The old code might be unfinished.

Creators have toggle switches to add or skip retimed handles. This feature was requested by a previous sponsor who used footage from the Phantom camera. They didn't need unretimed handles, as this would create a lot of extra work.

How to replicate the issue?

No response

Additional context:

link to discussion on Discord
(might be a private channel)

This issue was automatically created from Clickup ticket AY-6975

[robin-ynput]

Poking @jakubjezek001, I might need a bit more context here about what should be implemented exactly.

1. From what I could fine Flame OTIO exporter handles LinearTimeWarp and FreezeFrame time effects, which makes me think we'll encounter the same bugs I found with Hiero in ayon-core (see Bring back publishing of clip retimes ayon-hiero#29 (comment)). So those will have to be fixed.

2. retimedFramerange I could not really figure out this option from the code. From what I can see this is really flame-specific right now and allows to override the plate instance frameEnd value with retimed duration (https://github.com/ynput/ayon-core/blob/79903e4875b228762edcceab327b523465b18ee3/client/ayon_core/plugins/publish/collect_otio_frame_ranges.py#L66). From what I can see, this is the only part this setting is ever used.

Im not sure I understand the initial intent for this, could you please explain the use-case ?
Also it has limited effect right now:

• representations for plate products get created from collect_otio_subset_resources.py which ignores this
• the shot creation process is left unchanged wherever this is enabled or not

3. retimedHandles when this is enabled and clip is retimed, this applies the retiming operation to the handles and adjust the instance values accordingly. This logic is only called in ayon-flame's extract_product_resource currently.

The handleStart / handleEnd values in the created shot do not seem to be impacted by this.
UX-wise I guess it could also help to only allow user to toogle retimedHandles and retimedFramerange if there is retiming on the clip. Other than that we could maybe ensure that freeze frame retime the handle to 0 (no handle) if that's the intended behavior.

Hope this will help.
Without prior context, I'm having a bit of hard time to determine what exactly needs to be done.