Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Customizations: MOTD (Login page message) preserve line breaks and other markdown culprits #1038

Open
BigRoy opened this issue Feb 20, 2025 · 5 comments

Comments

@BigRoy
Copy link
Contributor

BigRoy commented Feb 20, 2025

Story

You want to really perfect your login page, with nice info too. But unfortunately

hello
my
world

Comes out: hello my world

Image

And:

Welcome at AYON studio.
We are the cool kids.

Comes out on multiple lines with the URL, but lacks the line break where I want it.

Image

To reproduce

Steps to reproduce the behavior:

  1. Put in some nice messages, like the examples above.
  2. Formatting should be similar.

Expected behavior

  • No automatic line breaks around URLs
  • Preserve regular line breaks

Environment

  • Server version:
  • Server host OS:
  • Browser:
  • Client version:

Additional context

@BigRoy BigRoy added the type: bug Something isn't working label Feb 20, 2025
@BigRoy BigRoy changed the title Global Customizations: MOTD (Logic page message) preserve line breaks and other markdown culprits Global Customizations: MOTD (Login page message) preserve line breaks and other markdown culprits Feb 20, 2025
@Innders
Copy link
Member

Innders commented Feb 20, 2025

  1. The MOTD input box is not a markdown editor so those line breaks probably mean nothing when submitting the data.
  2. Looks like links are forcing a line break incorrectly in how the markdown is rendered. This is a CSS thing.

@BigRoy
Copy link
Contributor Author

BigRoy commented Feb 20, 2025

  1. The MOTD input box is not a markdown editor so those line breaks probably mean nothing when submitting the data.

Could it be? Or is that complicated? Maybe the backend could define a tag for that on the string attribute so that it spawns a Markdown editor instead?

@martastain
Copy link
Member

  1. The MOTD input box is not a markdown editor so those line breaks probably mean nothing when submitting the data.

Could it be? Or is that complicated? Maybe the backend could define a tag for that on the string attribute so that it spawns a Markdown editor instead?

We have code editor somewhere (used in the raw settings editor) so maybe SettingsField could accept syntax argument when widget is set to textarea.

@martastain
Copy link
Member

BTW: single line break in markdown shouldn't break the line. It is implemented like that sometimes in the wild, but you should use \n\n to get a new paragraph

@Innders
Copy link
Member

Innders commented Feb 20, 2025

I really think this so low priority we shouldn't waste time on it, extremely cosmetic.

@mkolar mkolar removed the type: bug Something isn't working label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants