Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7317_Password reset requirements hint #974

Open
ynbot opened this issue Jan 13, 2025 · 2 comments
Open

AY-7317_Password reset requirements hint #974

ynbot opened this issue Jan 13, 2025 · 2 comments
Assignees
Labels
sponsored This is directly sponsored by a client or community member

Comments

@ynbot
Copy link

ynbot commented Jan 13, 2025

Please describe the enhancement you have in mind and explain what the current shortcomings are?

Typing invalid password only shows this pop-up bottom right:

Image

How would you imagine the implementation of the enhancemenent?

The requirements are defined on the server, so maybe we can write them in plain english on the client.

Provide human-readable information about what's wrong.

Describe alternatives you've considered:

No response

Additional context:

link to discussion on Discord
(might be a private channel)

This issue was automatically created from Clickup ticket AY-7317

@ynbot ynbot added sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition labels Jan 13, 2025
@mkolar mkolar removed the type: enhancement Improvement of existing functionality or minor addition label Feb 7, 2025
@mkolar mkolar assigned flynput and unassigned Innders Feb 7, 2025
@Innders
Copy link
Member

Innders commented Feb 11, 2025

  • Password reset page
  • Users password set dialog

Image

@BigRoy
Copy link
Contributor

BigRoy commented Feb 17, 2025

The requirements are actually reported by the server in a 'readable manner' here

However changing the password does not 'raise' the same thing here with response here. Likely re-raising the message may sufficiently help to provide more details when it is actually wrong?

And hence lacks that information.

Also note that the minimum password length can be adjusted on the server side using ayonconfig so I wonder if it's worth it for the client to somehow request from the server what the requirements are - and then report those requirements to the user. So that the server is still in control of describing the current requirements? Otherwise we may not know about the password length check?

As such, this may be more related to the backend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member
Projects
None yet
Development

No branches or pull requests

5 participants