Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7242_Fix clip_media review source from Hiero. #38

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Dec 3, 2024

Changelog Description

When testing Flame and Hiero we realized that the [Clip media] option of Reviewable Source did not work properly.
Here is the bug fix for Hiero.

Additional review information

This changes needs to be tested alongside ynput/ayon-core#1036

Testing notes:

  1. Open Hiero and create instance(s) through the Create Publishable Clip
  2. Set the review source media to [Clip media]
    image
  3. Publish and ensure that the resulting review product is created from the original clip media entire range (untrimmed)

AY-7242

@robin-ynput robin-ynput self-assigned this Dec 3, 2024
@robin-ynput robin-ynput added the type: bug Something isn't working label Dec 3, 2024
@jakubjezek001
Copy link
Member

Awesome @robin-ynput this should be solid. We will also need to add it to Resolve and Flame. I wonder if we could simplify the code here and move the logic to ayon-core as suggested in the comments.

@robin-ynput
Copy link
Contributor Author

Awesome @robin-ynput this should be solid. We will also need to add it to Resolve and Flame. I wonder if we could simplify the code here and move the logic to ayon-core as suggested in the comments.

That's a good idea, I have made these changes in ayon_core: ynput/ayon-core#1036

@jakubjezek001 jakubjezek001 changed the title Fix clip_media review source from Hiero. AY-7242_Fix clip_media review source from Hiero. Dec 5, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@jakubjezek001 jakubjezek001 merged commit 73e2461 into develop Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants