Skip to content

Commit

Permalink
Remove legacy pop of the 'active' data on create of instance.
Browse files Browse the repository at this point in the history
This was a leftover from legacy creator where the active state was defined by the Bypass state of the node instead of a dedicated parm for the publisher.
  • Loading branch information
BigRoy committed Jul 13, 2024
1 parent 077af32 commit c076c01
Show file tree
Hide file tree
Showing 18 changed files with 0 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class CreateAlembicCamera(plugin.HoudiniCreator):
def create(self, product_name, instance_data, pre_create_data):
import hou

instance_data.pop("active", None)
instance_data.update({"node_type": "alembic"})

instance = super(CreateAlembicCamera, self).create(
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_arnold_ass.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class CreateArnoldAss(plugin.HoudiniCreator):
def create(self, product_name, instance_data, pre_create_data):
import hou

instance_data.pop("active", None)
instance_data.update({"node_type": "arnold"})
creator_attributes = instance_data.setdefault(
"creator_attributes", dict())
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_arnold_rop.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def create(self, product_name, instance_data, pre_create_data):
creator_attributes[key] = pre_create_data[key]

# Remove the active, we are checking the bypass flag of the nodes
instance_data.pop("active", None)
instance_data.update({"node_type": "arnold"})

# Add chunk size attribute
Expand Down
2 changes: 0 additions & 2 deletions client/ayon_houdini/plugins/create/create_bgeo.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ class CreateBGEO(plugin.HoudiniCreator):

def create(self, product_name, instance_data, pre_create_data):

instance_data.pop("active", None)

instance_data.update({"node_type": "geometry"})
creator_attributes = instance_data.setdefault(
"creator_attributes", dict())
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_composite.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class CreateCompositeSequence(plugin.HoudiniCreator):
def create(self, product_name, instance_data, pre_create_data):
import hou # noqa

instance_data.pop("active", None)
instance_data.update({"node_type": "comp"})

instance = super(CreateCompositeSequence, self).create(
Expand Down
8 changes: 0 additions & 8 deletions client/ayon_houdini/plugins/create/create_hda.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,14 +250,6 @@ def create_instance_node(

return hda_node

def create(self, product_name, instance_data, pre_create_data):
instance_data.pop("active", None)

return super(CreateHDA, self).create(
product_name,
instance_data,
pre_create_data)

def get_network_categories(self):
# Houdini allows creating sub-network nodes inside
# these categories.
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_karma_rop.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ def create(self, product_name, instance_data, pre_create_data):
if key in pre_create_data:
creator_attributes[key] = pre_create_data[key]

instance_data.pop("active", None)
instance_data.update({"node_type": "karma"})
# Add chunk size attribute
instance_data["chunkSize"] = 10
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_mantra_rop.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def create(self, product_name, instance_data, pre_create_data):
if key in pre_create_data:
creator_attributes[key] = pre_create_data[key]

instance_data.pop("active", None)
instance_data.update({"node_type": "ifd"})
# Add chunk size attribute
instance_data["chunkSize"] = 10
Expand Down
2 changes: 0 additions & 2 deletions client/ayon_houdini/plugins/create/create_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import hou



class CreateModel(plugin.HoudiniCreator):
"""Create Model"""
identifier = "io.openpype.creators.houdini.model"
Expand All @@ -26,7 +25,6 @@ class CreateModel(plugin.HoudiniCreator):
icon = "cube"

def create(self, product_name, instance_data, pre_create_data):
instance_data.pop("active", None)
instance_data.update({"node_type": "alembic"})
creator_attributes = instance_data.setdefault(
"creator_attributes", dict())
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_pointcache.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class CreatePointCache(plugin.HoudiniCreator):
icon = "gears"

def create(self, product_name, instance_data, pre_create_data):
instance_data.pop("active", None)
instance_data.update({"node_type": "alembic"})
creator_attributes = instance_data.setdefault(
"creator_attributes", dict())
Expand Down
3 changes: 0 additions & 3 deletions client/ayon_houdini/plugins/create/create_redshift_proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ class CreateRedshiftProxy(plugin.HoudiniCreator):

def create(self, product_name, instance_data, pre_create_data):

# Remove the active, we are checking the bypass flag of the nodes
instance_data.pop("active", None)

# Redshift provides a `Redshift_Proxy_Output` node type which shows
# a limited set of parameters by default and is set to extract a
# Redshift Proxy. However when "imprinting" extra parameters needed
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_redshift_rop.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def create(self, product_name, instance_data, pre_create_data):
if key in pre_create_data:
creator_attributes[key] = pre_create_data[key]

instance_data.pop("active", None)
instance_data.update({"node_type": "Redshift_ROP"})
# Add chunk size attribute
instance_data["chunkSize"] = 10
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_review.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def apply_settings(self, project_settings):

def create(self, product_name, instance_data, pre_create_data):

instance_data.pop("active", None)
instance_data.update({"node_type": "opengl"})
instance_data["imageFormat"] = pre_create_data.get("imageFormat")
instance_data["keepImages"] = pre_create_data.get("keepImages")
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_usd.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class CreateUSD(plugin.HoudiniCreator):

def create(self, product_name, instance_data, pre_create_data):

instance_data.pop("active", None)
instance_data.update({"node_type": "usd"})

instance = super(CreateUSD, self).create(
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_usd_look.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class CreateUSDLook(plugin.HoudiniCreator):

def create(self, product_name, instance_data, pre_create_data):

instance_data.pop("active", None)
instance_data.update({"node_type": "usd"})

instance = super(CreateUSDLook, self).create(
Expand Down
2 changes: 0 additions & 2 deletions client/ayon_houdini/plugins/create/create_usdrender.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ def create(self, product_name, instance_data, pre_create_data):
# TODO: Support creation in /stage if wanted by user
# pre_create_data["parent"] = "/stage"

# Remove the active, we are checking the bypass flag of the nodes
instance_data.pop("active", None)
instance_data.update({"node_type": "usdrender"})

# Override default value for the Export Chunk Size because if the
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_vbd_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class CreateVDBCache(plugin.HoudiniCreator):
def create(self, product_name, instance_data, pre_create_data):
import hou

instance_data.pop("active", None)
instance_data.update({"node_type": "geometry"})
creator_attributes = instance_data.setdefault(
"creator_attributes", dict())
Expand Down
1 change: 0 additions & 1 deletion client/ayon_houdini/plugins/create/create_vray_rop.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def create(self, product_name, instance_data, pre_create_data):
if key in pre_create_data:
creator_attributes[key] = pre_create_data[key]

instance_data.pop("active", None)
instance_data.update({"node_type": "vray_renderer"})
# Add chunk size attribute
instance_data["chunkSize"] = 10
Expand Down

0 comments on commit c076c01

Please sign in to comment.