Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better communication between publisher and rops #16

Open
2 tasks done
MustafaJafar opened this issue Jul 4, 2024 · 3 comments · May be fixed by #2
Open
2 tasks done

Better communication between publisher and rops #16

MustafaJafar opened this issue Jul 4, 2024 · 3 comments · May be fixed by #2
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@MustafaJafar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

In Houdini addon we faced a problem when ROP node's parameters needs to be updated to match user selection in the publisher.
e.g. changing the render target requires updating some parameters on the ROP node respectively.
image

Currently, The logic responsible for setting ROP's attributes to favorite values, lives in the extractors.
which is against pyblish concepts.

https://github.com/ynput/ayon-core/blob/6df1a97446d485badcd91c5ae353c5a7962ac757/server_addon/houdini/client/ayon_houdini/plugins/publish/extract_render.py#L25-L43

How would you imagine the implementation of the feature?

We need to figure out a way to sync the ROP's state with the selected options in the publisher.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

There was an experimental PR ynput/ayon-core#418 but it increased the complexity of the plugin.
Its idea was to set node's parameters when clicking save in the publisher and set the options to match the node when resetting the publisher.

Additional context:

No response

@MustafaJafar
Copy link
Contributor Author

I'd like to mention that #2 implements a logic that achieves the mentioned enhancement request in this issue.

As the node parameters and the publisher attributes are synced.
From the node to the publisher and from the publisher to the node.
That logic is implemented in collect_instances by reading the rop parameters, creating the instance manually and adding it to the context and update_instances by the imprint method that propagates the changes from the publisher to the node.

Tagging @BigRoy for visibility.

@antirotor antirotor linked a pull request Oct 1, 2024 that will close this issue
13 tasks
@antirotor
Copy link
Member

I've linked this issue to #2 so it will resolve this. Is there anything else needed?

This ynput/ayon-core#860 can help with syncing per instance attributes.

@MustafaJafar
Copy link
Contributor Author

Is there anything else needed?

I think it's cool as my test here is ynput/ayon-core#860 (review) the desired behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants