Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/remove the farm related family based on creator attribute changes #177

Open
1 task done
MustafaJafar opened this issue Nov 19, 2024 · 0 comments
Open
1 task done

Comments

@MustafaJafar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

add/remove the farm related family based on creator attribute changes

Suggested implementation?

Let me quote @BigRoy's comment #149 (comment)

value change callback on the creator which adds/removes the farm related family based on the enum's state.

One could approach it the opposite so that all this logic is in the Deadline plug-in to watch for creator attribute changes, however that means it's up to that plug-in to detect whether "farm is enabled" on the attribute which makes it harder to maintain over time if we want to expose the toggle in the creator a different way. Or like add a different additional toggle or whatever. Plus one would then need to duplicate that logic to ALL farm integrations (if there were more than Deadline) and hence it'd mean more maintenance, instead of all integrations just watching for some farm.publish family for example.

Describe alternatives you've considered:

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant