You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ValidateAnimationSettings and ValidateFrameToken are exact duplicates.
Some other plugins overlap:
group 1: Same output node check
ValidateAlembicInputNode
ValidateAbcPrimitiveToDetail
ValidatePrimitiveHierarchyPaths
group 2: Same most of path attribute checks
ValidateAbcPrimitiveToDetail
ValidatePrimitiveHierarchyPaths
group 3: same current file check
SaveCurrentScene
IncrementCurrentFile
get_invalid should return None or a list of invalid nodes.
even if the SelectInvalidAction is not added to the validator, I'd stick to always return None or a list of invalid nodes for consistnecy.
a lot of plugins return node.path() which is wrong.
a lot of plugins return instance which is wrong.
Suggested implementation?
.
Describe alternatives you've considered:
.
The text was updated successfully, but these errors were encountered:
Is there an existing issue for this?
Please describe the feature you have in mind and explain what the current shortcomings are?
While making this PR #193
I found out that some plugins are redundant
ValidateAnimationSettings
andValidateFrameToken
are exact duplicates.Some other plugins overlap:
ValidateAlembicInputNode
ValidateAbcPrimitiveToDetail
ValidatePrimitiveHierarchyPaths
ValidateAbcPrimitiveToDetail
ValidatePrimitiveHierarchyPaths
SaveCurrentScene
IncrementCurrentFile
get_invalid
should return None or a list of invalid nodes.even if the
SelectInvalidAction
is not added to the validator, I'd stick to always return None or a list of invalid nodes for consistnecy.node.path()
which is wrong.instance
which is wrong.Suggested implementation?
.
Describe alternatives you've considered:
.
The text was updated successfully, but these errors were encountered: