Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup publish plugins #194

Open
1 task done
MustafaJafar opened this issue Dec 12, 2024 · 0 comments
Open
1 task done

Cleanup publish plugins #194

MustafaJafar opened this issue Dec 12, 2024 · 0 comments
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))

Comments

@MustafaJafar
Copy link
Contributor

MustafaJafar commented Dec 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

While making this PR #193

I found out that some plugins are redundant

  • ValidateAnimationSettings and ValidateFrameToken are exact duplicates.

Some other plugins overlap:

  • group 1: Same output node check
    • ValidateAlembicInputNode
    • ValidateAbcPrimitiveToDetail
    • ValidatePrimitiveHierarchyPaths
  • group 2: Same most of path attribute checks
    • ValidateAbcPrimitiveToDetail
    • ValidatePrimitiveHierarchyPaths
  • group 3: same current file check
    • SaveCurrentScene
    • IncrementCurrentFile

get_invalid should return None or a list of invalid nodes.
even if the SelectInvalidAction is not added to the validator, I'd stick to always return None or a list of invalid nodes for consistnecy.

  • a lot of plugins return node.path() which is wrong.
  • a lot of plugins return instance which is wrong.

Suggested implementation?

.

Describe alternatives you've considered:

.

@MustafaJafar MustafaJafar added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Development

No branches or pull requests

1 participant