Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: USD Render wrong colorspace #49

Closed
2 tasks done
MustafaJafar opened this issue Jul 19, 2024 · 2 comments · Fixed by #75
Closed
2 tasks done

Houdini: USD Render wrong colorspace #49

MustafaJafar opened this issue Jul 19, 2024 · 2 comments · Fixed by #75
Assignees
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working

Comments

@MustafaJafar
Copy link
Contributor

MustafaJafar commented Jul 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

"colorspaceData": {
    "colorspace": "",
    "config": {
        "path": "C:/Users/.....Documents/houdini20.0/ocio/houdini-config-v1.0.0_aces-v1.3_ocio-v2.1.ocio",
        "template": "C:/Users/..../Documents/houdini20.0/ocio/houdini-config-v1.0.0_aces-v1.3_ocio-v2.1.ocio"
    },
    "display": "sRGB - Display",
    "view": "ACES 1.0 - SDR Video"
},

Which seems to be the wrong OCIO config?
Also, it reports "colorspace": null for the instance itself, which makes me think it's also not correctly detecting the colorspace of the output product.
You're using Karma XPU?
Yes.

Expected Behavior:

.

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

..

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

No response

Additional context:

No response

@MustafaJafar MustafaJafar added type: bug Something isn't working sponsored This is directly sponsored by a client or community member labels Jul 19, 2024
@BigRoy BigRoy self-assigned this Jul 19, 2024
@BigRoy
Copy link
Contributor

BigRoy commented Jul 19, 2024

"colorspaceData": {
    "colorspace": "",
    "config": {
        "path": "C:/Users/.....Documents/houdini20.0/ocio/houdini-config-v1.0.0_aces-v1.3_ocio-v2.1.ocio",
        "template": "C:/Users/..../Documents/houdini20.0/ocio/houdini-config-v1.0.0_aces-v1.3_ocio-v2.1.ocio"
    },
    "display": "sRGB - Display",
    "view": "ACES 1.0 - SDR Video"
},

Which seems to be the wrong OCIO config?

So... this does actually work currently:

>>> get_color_management_preferences()
{'config': 'P:/Resources/colorspace/studio-config-v1.0.0_aces-v1.3_ocio-v2.1/studio-config-v1.0.0_aces-v1.3_ocio-v2.1.ocio', 'display': 'sRGB - Display', 'view': 'Un-tone-mapped'}

Anyway, will look into collecting the colorspace of the renderlayers, etc.

@BigRoy
Copy link
Contributor

BigRoy commented Jul 19, 2024

Also, it's defaulting to the default display/view colorspace:

instance.data["renderProducts"] = colorspace.ARenderProduct()

Which gets the defaults from here:

def get_colorspace_data(self):
"""To be implemented by renderer class.
This should return a list of RenderProducts.
Returns:
list: List of RenderProduct
"""
data = get_color_management_preferences()
colorspace_data = [
RenderProduct(
colorspace=data["display"],
view=data["view"],
productName=""
)
]
return colorspace_data

@BigRoy BigRoy changed the title Houdini render wrong colorspace Houdini: USD Render wrong colorspace Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
2 participants