AY-7442 Dissociate file_type and ext knob computation (SXR and JPG extension support). #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-ynput
added
type: enhancement
robin-ynput
changed the title
robin-ynput
commented
Feb 26, 2025
| # Determine defined file type | ||
| path = node["file"].value() | ||
| _, ext = os.path.splitext(path) | ||
| _, ext = ext.split(".", 1) |
There was a problem hiding this comment.
This would mean the file extension drives the representation name and not the file_type anymore, is that OK ?
This means those would be different jpg vs jpeg and exr vs sxr
There was a problem hiding this comment.
Would be question for @jakubjezek001 .
There was a problem hiding this comment.
yes, and the solution is great! We will need to also add this into documentation please. Ideally around this section please https://ayon.ynput.io/docs/addon_nuke_admin#creator-plugins
iLLiCiTiT
reviewed
Feb 27, 2025
| ext = write_node["file_type"].value() | ||
| path = write_node["file"].value() | ||
| _, ext = os.path.splitext(path) | ||
| _, ext = ext.split(".", 1) |
There was a problem hiding this comment.
Suggested change
| _, ext = ext.split(".", 1) | |
| ext = ext.lstrip(".") |
iLLiCiTiT
reviewed
Feb 27, 2025
Comment on lines
+167
to
+168
| _, ext = os.path.splitext(path) | ||
| _, ext = ext.split(".", 1) |
There was a problem hiding this comment.
Suggested change
| _, ext = os.path.splitext(path) | |
| _, ext = ext.split(".", 1) | |
| ext = os.path.splitext(path)[1].lstrip(".") |
BigRoy
reviewed
Feb 27, 2025
| nuke.message( | ||
| "ERROR: No file type found in the subset's knobs." | ||
| "ERROR: No 'file_type' nor 'ext' found in the subset's knobs." |
There was a problem hiding this comment.
Should this subset be refactored to product now too? While we're at it.
Suggested change
| "ERROR: No 'file_type' nor 'ext' found in the subset's knobs." | |
| "ERROR: No 'file_type' nor 'ext' found in the product's knobs." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
resolve: #69
resolve: #72
Changes to ensure SXR (exr) and JPG (jpeg) can be rendered out of our
Renderwrite nodes through AYON settings.Needs to be tested with ynput/ayon-core#1165 to ensure loader is OK.
Additional review information
Current implementation in Nuke assumes that
file_typeand output file extension are always matching.However Nuke has some disperencies here:
These changes ensure extension is set from an
extknob if defined, then computed from thepathknob.Testing notes:
Render SXR output:
Render (write)node knobs settings (ayon+settings://nuke/imageio/nodes/required_nodes/0/knobs) to:file_type: exr (Text)ext: sxr (Text)Render JPG output:
Set
Render (write)node knobs settings (ayon+settings://nuke/imageio/nodes/required_nodes/0/knobs) to:file_type: jpeg (Text)ext: jpg (Text)Create a new
RenderproductPublisher the
RenderproductEnsure the
sxrorjpgrepresentation if properly published