AY-7475 - Define default render targets through settings. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-ynput
added
type: enhancement
iLLiCiTiT
reviewed
Feb 27, 2025
Comment on lines
+444
to
+453
| farm_rendering_targets = { | ||
| "frames_farm": "Use existing frames - farm", | ||
| "farm": "Farm rendering", | ||
| } | ||
|
|
||
| if ( | ||
| "farm_rendering" in self.instance_attributes | ||
| or self.render_target in farm_rendering_targets | ||
| ): | ||
| rendering_targets.update(farm_rendering_targets) |
There was a problem hiding this comment.
I don't think we should add farm options just because you have farm value set in settings as default -> it's hiding wrong settings.
Suggested change
| farm_rendering_targets = { | |
| "frames_farm": "Use existing frames - farm", | |
| "farm": "Farm rendering", | |
| } | |
| if ( | |
| "farm_rendering" in self.instance_attributes | |
| or self.render_target in farm_rendering_targets | |
| ): | |
| rendering_targets.update(farm_rendering_targets) | |
| if "farm_rendering" in self.instance_attributes: | |
| rendering_targets.update({ | |
| "frames_farm": "Use existing frames - farm", | |
| "farm": "Farm rendering", | |
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Resolve: #74
Add new settings to be able to define default render targets for
Render,ImageandPrerendercreatorsTesting notes:
Create new package and upload it to AYON server
Edit newly created settings:
ayon+settings://nuke/create/CreateWriteImage/render_targetayon+settings://nuke/create/CreateWritePrerender/render_targetayon+settings://nuke/create/CreateWriteRender/render_targetIn Nuke open
Creatorwidget and ensure default render target(s) are properly gathered from settings