Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display and View fallback options for settings and api #10

Merged
merged 16 commits into from
Sep 30, 2024
Merged

Display and View fallback options for settings and api #10

merged 16 commits into from
Sep 30, 2024

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Aug 1, 2024 •
edited
Loading

After adding support for context-specific anatomy token resolution in color management display and view options, we must now ensure value validation and provide fallback options. We're introducing a semicolon separator in values, allowing for multiple options where the order is important.

Additional informations

  • colorspace methods were moved from lib to new nuke API module colorspace.py. Some of those function might need to move into core addon but for now lets keep them here.

Testing notes

Pre testing

  • version up dev number in package.py
  • deploy addon version to your server and bundle
  • make sure core colormanagement is enabled
  • notice hints on ayon+settings://nuke/imageio/viewer/display

How to do DCC testing

  • When conducting this testing, it is important to note that a published ocio config may not be present in your task context. Our objective is to determine the backward compatibility of the process and identify any potential issues. It is possible for only certain shot folders to have published ocio configurations, while others may not. In such scenarios, a fallback option must be available.
  • In addition to this PR, the changes in Refactor OCIO config handling, introduce fallback mechanism ayon-core#834 also need to be deployed. Once completed, the colorspace settings in the core addon should be adjusted to use the fallback option. The built-in ACES 1.2 should be selected for this purpose.

  1. To test baking targeting it would be good to disable clearing nodes in your code here ayon-nuke\client\ayon_nuke\api\plugin.py:1090 - just add # on line start. Then after open Nuke. This way baking nodes created during ExtractReviewIntermediates processing will stay in script and you would be able to check how they are set.

  2. Follow next setps where we fork into two different testing
    a. Baking Target Colorspace (Use Display & View)
    - set {project[code]}_{parent}_{folder[name]};sRGB into View here ayon+settings://nuke/imageio/baking_target/display_view/view
    - Go to Nuke and publish render node
    - Check what is set into node just before write node.
    - it should be set to sRGB if ocio config is set to different then published product.

    b. Baking Target Colorspace (Use Colorspace)
    - set {project[code]}_{parent}_{folder[name]};Output - Rec.709 into View here ayon+settings://nuke/imageio/baking_target/colorspace
    - Go to Nuke and publish render node
    - Check what is set into node just before write node.
    - it should be set to Output - Rec.709 if ocio config is set to different then published product.

@jakubjezek001
Add COLOR_VALUE_SEPARATOR constant and update display and view profil…
2155c33 
…e formatting.

- Added COLOR_VALUE_SEPARATOR constant to separate color values.
- Updated the display and view profile formatting method to handle multiple colorspaces separated by the defined separator.
@jakubjezek001
Update display and view settings
36bec51 
Update display and view settings descriptions to include dynamic value setting and fallback options using semicolon separators.

Added detailed descriptions for display and view settings, explaining dynamic value setting with anatomy context tokens and fallback options using semicolons. Examples provided.
@jakubjezek001 jakubjezek001 added the type: enhancement Improvement of existing functionality or minor addition label Aug 1, 2024
BigRoy
BigRoy reviewed Aug 1, 2024
View reviewed changes
client/ayon_nuke/api/lib.py Outdated Show resolved Hide resolved
BigRoy
BigRoy reviewed Aug 1, 2024
View reviewed changes
client/ayon_nuke/api/lib.py Outdated Show resolved Hide resolved
@moonyuet
Copy link
Member

moonyuet commented Aug 2, 2024

I tried with this setting below:
image
nuke launched with the display and view setting
image
The context works without issue.
image

@jakubjezek001
Add Nuke Colorspace related methods and caching mechanisms.
8d6070b 
Include functions to get colorspaces, check colorspace existence on a node, create viewer profile strings, format display and view profiles into strings or dictionaries, and format colorspace profile names.

- Added methods for retrieving display and view colorspaces
- Implemented function to obtain available colorspace profile names
- Included functionality to check if a colorspace exists on a node
- Created functions for generating viewer profile strings
- Developed methods for formatting display and view profiles into strings or dictionaries
- Added function to format colorspace profile names
@jakubjezek001
Refactor: Move colorspace-related functions to separate module
8952e2b 
Detailed description:
- Moved colorspace functions from utils to a new module called colorspace
- Updated imports and references in lib.py
- Added TODOs for further refactoring of related functions
@jakubjezek001
Update plugin imports and formatting functions
88777e9 
Add new colorspace methods, and enhance display and view handling in ExporterReviewMov class.

- Updated plugin imports to include new functions
- Added methods for formatting anatomy and colorspace
- Enhanced display and view handling logic
@jakubjezek001
Refactor splitting logic for view and display values
3c73fc2 
Simplify the code by handling view and display value splitting consistently.
@jakubjezek001
Copy link
Member Author

I tried with this setting below

@moonyuet thank you very much for the testing. Yeah that is looking promissing. I wonder if you could rather use anatomy tokens, something like {project[code]}_{parent}_{folder[name]};sRGB
image

This way we should be able to even test that formating on context is working.

@moonyuet
Copy link
Member

moonyuet commented Aug 9, 2024

I tried with this setting below

@moonyuet thank you very much for the testing. Yeah that is looking promissing. I wonder if you could rather use anatomy tokens, something like {project[code]}_{parent}_{folder[name]};sRGB image

This way we should be able to even test that formating on context is working.

It's working
image
image

@jakubjezek001
Remove unused import statement from colorspace module
18bba07 
The commit removes an unused import statement from the colorspace module.
@jakubjezek001
Refactor caches to use prefixed variables
ba6475b 
- Renamed global cache variables for clarity and consistency.
- Updated cache access and assignment throughout the code.
moonyuet
moonyuet approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with baking colorspace looks good
image
I even tested with other parameters too:
image

And the view transform one(I tried with different parameters):
image

So far so good.

jakubjezek001 and others added 4 commits September 11, 2024 11:47
@jakubjezek001
Merge branch 'develop' into enhancement/AY-6198_OCIO-fallback-for-pro…
b856b40 
…files-and-templated-values
@jakubjezek001
Remove unused function 'format_anatomy' from plugin file
ae2efd4 
The commit removes the unused function 'format_anatomy' from the plugin file.
@jakubjezek001 @iLLiCiTiT
Update client/ayon_nuke/api/colorspace.py
1bd1d36 
Co-authored-by: Jakub Trllo <[email protected]>
@jakubjezek001
Add handling for config without displays and specify colorspace in OCIO.
cda388e 
- Added logic to handle configuration without displays by setting a default value.
- Updated the comment to clarify that the colorspace should exist in the running OCIO configuration session.
moonyuet
moonyuet approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good for merge after resolving the cosmetic.
Viewer
image
Bake Colorspace(Use Colorspace)
image
Bake Colorspace(Display & View)
image

@jakubjezek001 jakubjezek001 merged commit 9f0d41a into develop Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

@BigRoy BigRoy Awaiting requested review from BigRoy

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@jakubjezek001 jakubjezek001

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubjezek001 @moonyuet @BigRoy @iLLiCiTiT