Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Extract Nuke camera as FBX file. #15

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Sep 2, 2024

Changelog Description

This PR addresses: AY-6599

  • Add support to extract camera as FBX file
  • Add a new package server setting for a switch between ABC and FBX
  • Ensure loader support generated FBX properly

Additional info

Tested with Nuke 15.1v2

Testing notes:

  1. Build ayon-nuke package and upload it to server

  2. Ensure Export to FBX is set in newly added Nuke -> Publish Plugins -> Extract Camera Format presets
    ayon+settings://nuke/publish/ExtractCameraFormat/export_camera_format
    image

  3. Create and Publish a new camera from Nuke

  4. Ensure resulting camera can be properly loaded back

@robin-ynput robin-ynput added the type: enhancement Improvement of existing functionality or minor addition label Sep 2, 2024
@robin-ynput robin-ynput self-assigned this Sep 2, 2024
"Could not load incoming FBX camera properly. "
"This could be caused by a mix of abc and fbx "
"into the script."
)
Copy link
Contributor Author

@robin-ynput robin-ynput Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reproduce this by trying to load a mix of Camera from published ABC and FBX files:

  1. Load an ABC camera
  2. Append a FBX camera to the same Nuke scene
  3. FBX Camera node is not properly loaded

After some investigation I feel this is coming from Nuke trying to be smart and re-using the fbx_node_name knob.

for Alembic
image

for FBX
image

@robin-ynput robin-ynput requested a review from moonyuet September 3, 2024 16:44
@BigRoy BigRoy linked an issue Sep 3, 2024 that may be closed by this pull request
@robin-ynput robin-ynput requested a review from moonyuet September 4, 2024 10:57
@robin-ynput robin-ynput merged commit e6ea7b6 into develop Sep 5, 2024
1 check passed
@robin-ynput robin-ynput deleted the enhancement/AY-6599_export_camera_fbx branch September 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-6599_Nuke: settings with options for ExtractCamera
4 participants