generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Extract Nuke camera as FBX file. #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-ynput
added
the
type: enhancement
Improvement of existing functionality or minor addition
label
Sep 2, 2024
robin-ynput
commented
Sep 2, 2024
"Could not load incoming FBX camera properly. " | ||
"This could be caused by a mix of abc and fbx " | ||
"into the script." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can reproduce this by trying to load a mix of Camera from published ABC and FBX files:
- Load an ABC camera
- Append a FBX camera to the same Nuke scene
- FBX Camera node is not properly loaded
After some investigation I feel this is coming from Nuke trying to be smart and re-using the fbx_node_name knob.
MilaKudr
approved these changes
Sep 3, 2024
moonyuet
reviewed
Sep 4, 2024
moonyuet
reviewed
Sep 4, 2024
moonyuet
reviewed
Sep 4, 2024
Co-authored-by: Kayla Man <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR addresses: AY-6599
Additional info
Tested with Nuke 15.1v2
Testing notes:
Build ayon-nuke package and upload it to server
Ensure Export to FBX is set in newly added
Nuke -> Publish Plugins -> Extract Camera Format
presetsayon+settings://nuke/publish/ExtractCameraFormat/export_camera_format
Create and Publish a new camera from Nuke
Ensure resulting camera can be properly loaded back