Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7163_🚀 Flow 2ways Sync #130

Open
5 of 7 tasks
dee-ynput opened this issue Sep 10, 2024 · 5 comments
Open
5 of 7 tasks

AY-7163_🚀 Flow 2ways Sync #130

dee-ynput opened this issue Sep 10, 2024 · 5 comments
Assignees
Labels
sponsored This is directly sponsored by a client or community member

Comments

@dee-ynput
Copy link

dee-ynput commented Sep 10, 2024

SubEpic of 🚀 Prod Trackers 2ways Sync

Strategy

Flow addon must support two ways synchronization of all relevant data.
This includes syncronizing:

  • One way sync of User
  • Entity hierarchy (anatomy and entities themselves)
  • Entity attributes (anatomy and attributes values on entities)
  • Statuses
  • Assignments
  • Comments
  • Reviewables #151

Generic User Stories

(Applicable for each of the checkbox in the strategy section)

  • As an Artist or Lead, when I [do something] in the production tracker, I want the changes to be visible in AYON.
  • As an Artist or Lead, when I [do something] in AYON Activity Feed, I the changes to be visible in the production tracker.

Related dev

AY-7217_Add support to sync task assignees and statuses for all entities

@dee-ynput dee-ynput added type: enhancement Improvement of existing functionality or minor addition type: feature Adding something new and exciting to the product labels Sep 10, 2024
@jakubjezek001
Copy link
Member

I believe the two-way synchronization of statuses and assignments is already done, but it needs to be tested. As far as I remember, it was implemented by @fabiaserra.

@fabiaserra
Copy link
Contributor

I believe the two-way synchronization of statuses and assignments is already done, but it needs to be tested. As far as I remember, it was implemented by @fabiaserra.

That's correct, it's been working fine for us

@jakubjezek001
Copy link
Member

I believe the two-way synchronization of statuses and assignments is already done, but it needs to be tested. As far as I remember, it was implemented by @fabiaserra.

That's correct, it's been working fine for us

It looks like it's only working on your fork. I checked the assignees, and there's no sign that we're syncing user assignments on tasks. This might be because we haven't merged User syncing #76 yet.

@fabiaserra
Copy link
Contributor

It looks like it's only working on your fork. I checked the assignees, and there's no sign that we're syncing user assignments on tasks. This might be because we haven't merged User syncing #76 yet.

Hmmm that shouldn't be necessary, although perhaps thanks to that functionality I can make some assumptions due to our login field in SG matching the username in AYON without having to do extra gimmicks: https://github.com/fabiaserra/ayon-shotgrid/blob/release/alkemyx/services/shotgrid_common/utils.py#L686

Coincidentally, I just finished a refactor of the user syncing functionality in our fork so it syncs the users and its project access (or role if they are admin, management and producers so they have access to all projects) automatically when there's a project assignment event in Shotgrid so you don't have to click any button. Here are the relevant changes on that: https://github.com/fabiaserra/ayon-shotgrid/blob/release/alkemyx/services/shotgrid_common/ayon_shotgrid_hub/update_from_shotgrid.py#L467 and https://github.com/fabiaserra/ayon-shotgrid/blob/release/alkemyx/services/leecher/leecher/listener.py#L109

And I also added support for when there's hierarchy changes in the Shotgrid project (a shot gets parented to a sequence after the sync already happened) those get re-parented as expected, that change was done here: https://github.com/fabiaserra/ayon-shotgrid/blob/release/alkemyx/services/shotgrid_common/ayon_shotgrid_hub/match_shotgrid_hierarchy_in_ayon.py#L133

@fabiaserra
Copy link
Contributor

It looks like it's only working on your fork. I checked the assignees, and there's no sign that we're syncing user assignments on tasks. This might be because we haven't merged User syncing #76 yet.

Well duh, I see that you never merged this other PR either #113, this one is the one relevant to get that functionality working

@mkolar mkolar removed type: enhancement Improvement of existing functionality or minor addition type: feature Adding something new and exciting to the product labels Nov 5, 2024
@m-u-r-p-h-y m-u-r-p-h-y changed the title 🚀 Flow 2ways Sync AY-7163_🚀 Flow 2ways Sync Nov 18, 2024
@m-u-r-p-h-y m-u-r-p-h-y added the sponsored This is directly sponsored by a client or community member label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member
Projects
None yet
Development

No branches or pull requests

6 participants