Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ocio_config ImageIOConfigModel settings #3

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 17, 2024

Changelog Description

Remove deprecated ocio_config ImageIOConfigModel settings

Additional info

With the support of profiles to determine OCIO config in ayon-core this logic has been superseded and should be removed from each addon still having the deprecated settings.

@BigRoy BigRoy requested review from iLLiCiTiT and moonyuet July 17, 2024 18:49
@BigRoy BigRoy self-assigned this Jul 17, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both enable or disable color management in core addon and project configuration of color management in Substance Painter work as expected after the removal of the related settings in SP addon

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@BigRoy BigRoy merged commit 0718e5a into develop Jul 18, 2024
1 check passed
@BigRoy BigRoy deleted the chore/remove_deprecated_imageioconfig branch July 18, 2024 18:12
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants