Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error on Collect Workfile Representations if current file is unsaved #7

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Aug 28, 2024

Changelog Description

Do not error on Collect Workfile Representation if current file is unsaved. Allow invalidation by validators.

Additional info

This is a companion PR to ynput/ayon-core#786
When used together a better error report is shown for unsaved files.

image

(Screenshots from Houdini - should appear similar in Substance painter)

Testing notes:

  1. Use this PR together with Better validation report when publishing from unsaved workfile ayon-core#786
  2. Try publishing from an unsaved workfile

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Aug 28, 2024
@BigRoy BigRoy requested a review from moonyuet August 28, 2024 18:51
@BigRoy BigRoy self-assigned this Aug 28, 2024
@moonyuet
Copy link
Member

It won't error out workfile representation collector anymore.
image

image

@BigRoy BigRoy merged commit 0e50406 into develop Aug 29, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/improve_validation_unsaved_workfile branch August 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants