Use task entity attributes instead of folder entity attributes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
added
the
type: enhancement
iLLiCiTiT
reviewed
Sep 11, 2024
| @@ -2,14 +2,14 @@ | |||
|
|
|||
|
|
|||
| class CollectFrameDataFromAssetEntity(pyblish.api.InstancePlugin): | |||
There was a problem hiding this comment.
Can we change the plugin name too? (e.g. CollectFrameDataFromEntity )
There was a problem hiding this comment.
That'd require also to change the settings around - and hence deal with backwards compatibility there. Any examples that show how that's done?
iLLiCiTiT
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use task entity attributes instead of folder entity attributes, only if it is set for the instance.
Additional info
I'm not sure if I've missed any parts where it's also crucial to refactor them in
traypublisher. This is mostly a bit of 'search' in the code to see wherefolderseems relevant to update.Testing notes:
Not entirely sure how to test these use cases.