Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV ingest allow user override through AYON_USERNAME. #35

Merged
merged 2 commits into from
Oct 29, 2024
Merged

CSV ingest allow user override through AYON_USERNAME. #35

merged 2 commits into from
Oct 29, 2024

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Oct 28, 2024 •
edited
Loading

Changelog Description

resolve #34
The user should be able to override the user operating the CSV ingest through AYON_USERNAME when connection is made through a service account.

Additional info

Testing notes:

  1. Setup connection through a service account
  2. Set AYON_USERNAME environment variable to an existing user
  3. Run the CSV ingest command line
  4. Check that the created product are made under the user set through AYON_USERNAME

@robin-ynput robin-ynput self-assigned this Oct 28, 2024
@robin-ynput robin-ynput added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Oct 28, 2024
@robin-ynput robin-ynput marked this pull request as ready for review October 28, 2024 18:25
BigRoy
BigRoy approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It matches somewhat the code used here so I guess it makes sense - didn't do a test run though.

client/ayon_traypublisher/addon.py Outdated Show resolved Hide resolved
@iLLiCiTiT iLLiCiTiT merged commit 6563596 into develop Oct 29, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/make_clip_accept_service_user_name_override branch October 29, 2024 10:49
@Lonerobot
Copy link

awesome, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@BigRoy BigRoy BigRoy approved these changes

Assignees

@robin-ynput robin-ynput

Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AY-7013_CLI publish to accept service user name override
4 participants
@robin-ynput @Lonerobot @BigRoy @iLLiCiTiT