Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default values of ExtractEditorialPckgConversion #54

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix default values of ExtractEditorialPckgConversion #54

merged 1 commit into from
Dec 11, 2024

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

resolve #53
image

Testing notes:

  1. when enabled, the conversion should work.
  2. the setting should be backward compatible, copy settings should be fine.

@MustafaJafar MustafaJafar added the type: bug Something isn't working label Dec 10, 2024
@MustafaJafar MustafaJafar self-assigned this Dec 10, 2024
robin-ynput
robin-ynput approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@robin-ynput robin-ynput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed default settings changes as expected when uploading this update.
Thanks @MustafaJafar !

@MustafaJafar MustafaJafar mentioned this pull request Dec 10, 2024
Open
@MustafaJafar MustafaJafar merged commit 00427cc into develop Dec 11, 2024
5 checks passed
@MustafaJafar MustafaJafar deleted the 53-wrong-default-settings-for-extracteditorialpckgconversion branch December 11, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-ynput robin-ynput robin-ynput approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees

@MustafaJafar MustafaJafar

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong default settings for ExtractEditorialPckgConversion
2 participants
@MustafaJafar @robin-ynput