Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated opentimelineio 'each_child' methods (To Be Discussed). #7

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

robin-ynput
Copy link
Contributor

Changelog Description

When onboarding for the Resolve publisher work, I tried to make the EditorialSimple example working from the traypublisher but go some issues.

AttributeError: 'opentimelineio._otio.Timeline' object has no attribute 'each_child'

I'm using opentimelineio-0.16.0 which I believe is defined from
https://github.com/ynput/ayon-core/blob/874a0f1c4e308ec93828b8eef0487591b8ffd782/client/pyproject.toml#L17

So I think this is an issue which needs to be fixed, please @jakubjezek001 advise on this one 😃

Additional info

OpentimelineIO PR which remove each_child:
https://github.com/AcademySoftwareFoundation/OpenTimelineIO/pull/1437/files

Testing notes:

  1. Try to create an EditorialSimple from test resources

@robin-ynput robin-ynput self-assigned this Aug 19, 2024
@robin-ynput robin-ynput changed the title Fix deprecated opentimelineio 'each_child' methods. Fix deprecated opentimelineio 'each_child' methods (To Be Discussed). Aug 19, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the change is addressed it is good to be merged

@jakubjezek001 jakubjezek001 marked this pull request as ready for review August 20, 2024 11:39
@jakubjezek001 jakubjezek001 merged commit b23b749 into develop Aug 20, 2024
1 check passed
@jakubjezek001 jakubjezek001 deleted the draft/fix-deprecated-each_child branch August 20, 2024 11:39
@64qam 64qam added the type: enhancement Improvement of existing functionality or minor addition label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants