Change label list output to [] instead of none in case of no values

ynput · Sep 11, 2024 · ad1599f · ad1599f
1 parent ae64c19
commit ad1599f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/github_query.py b/github_query.py
@@ -102,10 +102,10 @@ def get_labels(pr_data: dict) -> list:
 
     for item in pr_data:
         if not item.get("labels"):
-            return
+            return []
         for label in item["labels"]:
             if not label.get("name"):
-                return
+                return []
 
             labels.add(label["name"])
 

diff --git a/tests/test_github_query.py b/tests/test_github_query.py
@@ -93,7 +93,7 @@ def test_get_labels(pr_api_output):
 def test_get_labels_missing_input(pr_api_output_missing_label):
     labels = github_query.get_labels(pr_data=pr_api_output_missing_label)
 
-    assert labels == None
+    assert labels == []
 
 
 # Version Increment test-cases