Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT TG][OPTIMIZERS] PORTS IMPORTANT RECURSIVE CONTENTS AND POWER/MACHINE.dm improvements #22810

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

wonderinghost
Copy link
Contributor

@wonderinghost wonderinghost commented Nov 17, 2024

nearing completion. @ me on discord if i forget

Document the changes in your pull request

Ports:

--
fully implements important recursive contents
--content is a listing system that tracks activity of marked objects or devices. if an item is removed from the round it clears signals left by it
implements the spatial grid
--more or less the same as line above but on a 32x32 grid. used by radios mainly but things like vent crawling or trams would take advantage of this
updates airlock/firelock code for performance improvements
updates power code. now recursive content accessible
depreciates HEAR1 flag and replaces it with important_recursive_content()

Why is this good for the game?

this ive been throwing on and off the back burner has gone on for long enough.
more server performance by lowering machine overtimes allows us to get away with cooler ideas while also improving user experience when playing

Testing

TBT

Changelog

🆑 Thx TG station devs that messed with this system. more to be thanked in completion of pr
rscadd: Added new things
rscdel: Removed old things
wip: This is work in progress
experimental: This is experimental
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Revert / Deletion Altoids is probably mad about this labels Nov 17, 2024
@AMyriad
Copy link
Contributor

AMyriad commented Nov 17, 2024

Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying.

Actually explaining what this does in greater detail is a huge help to both maintainers and anyone else reading your PR. At least try to list what you've changed.

@wonderinghost
Copy link
Contributor Author

Working on it once I get home. But from my understanding or if you read my last few attempts of porting the spatial grid it produces a grid to track radio communication for instance to make sure things end. The important recursive contents stuff also does the same but for something else I got to check once I get home

@wonderinghost wonderinghost changed the title [PORT TG] PORTS IMPORTANT RECURSIVE CONTENT AND SPATIAL GRID. FINAL ATTEMPT [PORT TG][OPTIMIZERS] PORTS IMPORTANT RECURSIVE CONTENTS AND POWER/MACHINE.dm improvements Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Revert / Deletion Altoids is probably mad about this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants