Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse_dns function needs error checking #63

Open
deadbits opened this issue Oct 28, 2015 · 3 comments
Open

reverse_dns function needs error checking #63

deadbits opened this issue Oct 28, 2015 · 3 comments

Comments

@deadbits
Copy link

reverse_dns will throw herror "Unknown host" exceptions on IP addresses that don't have a PTR record.

>>> import utilitybelt as ub
>>> ub.reverse_dns('1.54.140.138')
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "<input>", line 3, in reverse_dns
herror: [Errno 1] Unknown host
>>> print "why python gods why!"
why python gods why!
@sroberts
Copy link
Member

Yeah, that's probably a fairly good point.

@deadbits
Copy link
Author

I can make a PR to patch this later today. Just wanted to have the issue in for reference when I do :)

@krmaxwell
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants