Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with korean? #32

Open
Latrolage opened this issue Aug 27, 2024 · 22 comments
Open

Not working with korean? #32

Latrolage opened this issue Aug 27, 2024 · 22 comments

Comments

@Latrolage
Copy link

Latrolage commented Aug 27, 2024

I downloaded the ko.zip (for korean) from the torrent provided and extracted and renamed the folder so that the file structure is, for example: user_files/forvo_files/02louis11/김치통.opus, I regenerated the database in anki and the statistics show:
image
But when I got to yomitan's settings, and it tries to look up the default word "읽어", there is no reply from the audio server and the command line window anki was launched from says this:

/Applications/Anki.app/Contents/MacOS/anki
Anki starting...
Initial setup...
Preparing to run...
2024-08-27 14:43:43,285:INFO:aqt.mediasrv: Serving on http://127.0.0.1:62259
todo: windows paths in import screen
Starting main loop...
Initializing database. This make take a while...
(init_db) Adding entries from nhk16...
(make_nhk16_table) Cannot find entries file: /Users/user/Library/Application Support/Anki2/addons21/1045800357/user_files/nhk16_files/entries.json
(init_db) Adding entries from shinmeikai8...
(AJTJapaneseSource) Cannot find entries file: /Users/user/Library/Application Support/Anki2/addons21/1045800357/user_files/shinmeikai8_files/index.json
(init_db) Adding entries from forvo...
(init_db) Adding entries from jpod...
(init_db) Adding entries from jpod_alternate...
(init_db) Filling out JMdict forms...
Finished initializing database!
GET: /?term=%EC%9D%BD%EB%8B%A4&reading=%EC%9D%BD%EB%8B%A4
[]

I had it working with japanese before on both the anki addon and using run_server.py from this repository but doing the same steps with the korean files doesn't have the same results.

@Latrolage Latrolage changed the title Not working with other languages? Not working with korean? Aug 27, 2024
@quopquai
Copy link

quopquai commented Nov 20, 2024

It doesn't seem to be working for me either for both Korean and English! : ( But, Japanese does work!
I'm wondering if the URL name should be something different, ie, something different from:
http://localhost:5050/?sources=forvo&term={term}&reading={reading}

UPDATE: Sorry English is working perfectly well! - It's Korean that isn't working for some reason! Something to do with not being able to read the Hangul script I would guess???

Someone please help!!!

@ecsalamanc
Copy link

Same issue here. I suspect it's something wrong with this link too:
[http://localhost:5050/?sources=forvo&term={term}&reading={reading}]

What is the relationship between term/reading and my cards? I have my cards configured like this:
Screenshot 2025-01-10 at 12 36 46 AM

Screenshot 2025-01-10 at 12 37 17 AM

Any help much appreciated!

@yoyorast1
Copy link

yoyorast1 commented Jan 12, 2025

Try this. http://localhost:5050/?term={term}&reading={reading}

I followed xelieu's Japanese set up guide, all works for Korean.

https://xelieu.github.io/jp-lazy-guide/setupYomitanOnPC/

Try to follow the same steps, put the korean audio folder in the same folder as the guide.
2025_01_11_01-32__FZK

@quopquai
Copy link

...Can you show an image of your folder structure, because I think I've already put the korean audio folder in the same folder and it's still not working. Thanks! mine looks like this by the way...

Screenshot 2025-01-12 at 11 16 51

@yoyorast1
Copy link

2025_01_12_03-22__26S

There's 5 Japanese forvo folders in this one, the rest are all Korean. I don't have the languages separated by folders, all languages are in the same folder. It works for me.

@quopquai
Copy link

Thanks, I tried that and regenerated database with no luck! - Can't figure out what's wrong!?
It could just be a Mac thing

@yoyorast1
Copy link

yoyorast1 commented Jan 12, 2025

yomitan-settings-2025-01-12-02-44-30.json
Try this yomitan settings file, maybe there's something in there that will make it work.

I have the following dictionaries installed:
KRDICT JA rev.krdict_ko-ja_0924
CC100-Korean rev.CC100-ko-1223
발음 rev.ipa1

From here: https://github.com/Lyroxide/yomitan-ko-dic/releases/tag/1.0.0

Install the dicts first then import the settings file. (do not sanitize).

If it still doesn't work, maybe it's something specific from my Anki setup or with mac.

@ecsalamanc
Copy link

ecsalamanc commented Jan 12, 2025

Thanks, I tried that and regenerated database with no luck! - Can't figure out what's wrong!? It could just be a Mac thing

Watching the discussion here. Having the same issue as quopquai and also thinking it's a Mac thing. For the record, I just duplicated the forvo files next to my anki and manually look them up. It doesn't take too much time and it was better than forvo failing with other extensions.

Thanks yoyorast1 for your attention!

@quopquai
Copy link

Thanks for your help yoyorast1, I've just tried what you've suggested again with no luck!?

Screenshot 2025-01-12 at 12 00 10

Maybe manually looking them up like ecsalamanc is doing is the only choice for now, but I'm not satisfied! - I just want it to work!!!

@yoyorast1
Copy link

1045800357.zip

My local audio server addon, put it in your addons21 folder.

user_files folder is not included because the size is too big, make sure it looks like the screenshot I posted. user files - > forvo files -> all of the korean folders with audio.

@quopquai
Copy link

Thanks again, I've just swapped my old addon with your version, restarted Anki, regenerated database, checked the Custom URL is http://localhost:5050/?term={term}&reading={reading}, refreshed Yomitan page, but no luck! my folder structure looks like this now with just the Korean files and nothing else...

Screenshot 2025-01-12 at 12 24 20

@yoyorast1
Copy link

If you enter http://localhost:5050/ in your browser, do you see "Local Audio Server v1.7.0"?

@quopquai
Copy link

sorry about the delay. Yes I do.

Screenshot 2025-01-12 at 14 51 02

@yoyorast1
Copy link

yoyorast1 commented Jan 13, 2025

#22
2025_01_13_09-57__xgT

Make sure the bottom permission is turned on. I'm using Firefox.

@quopquai
Copy link

Thanks, I'm on Chrome which I think has a similar setting

Screenshot 2025-01-13 at 18 05 01

...should i try Firefox...hmm, hassle...

@ecsalamanc
Copy link

ecsalamanc commented Jan 14, 2025

I use Firefox and am having the same problem. All the permissions are allowed. I think there's a problem with the connection between anki and the files on the computer? Or maybe the yomitan audio link still isn't working? In essence, anki just can't pick up the local audio files, but the audio files themselves are all in the right place.

@ReimeiSky
Copy link

ReimeiSky commented Jan 14, 2025

By forvo, the extension assumes you mean the Japanese Forvo that's bundled with jpod, nhk16, and shinmeikai8. Make sure you have a config.json file in your user_files folder that looks like this (varies depending on where your Korean audio is; mine is in user_files/ko).

{
  "sources": [
    {
      "type": "nhk",
      "id": "nhk16",
      "path": "user_files/nhk16_files",
      "display": "NHK16 %s"
    },
    {
      "type": "ajt_jp",
      "id": "shinmeikai8",
      "path": "user_files/shinmeikai8_files",
      "display": "SMK8 %s"
    },
    {
      "type": "forvo",
      "id": "forvo",
      "path": "user_files/forvo_files",
      "display": "Forvo (%s)"
    },
    {
      "type": "jpod",
      "id": "jpod",
      "path": "user_files/jpod_files",
      "display": "Jpod101"
    },
    {
      "type": "jpod",
      "id": "jpod_alternate",
      "path": "user_files/jpod_alternate_files",
      "display": "JPod101 Alt"
    },
    {
      "type": "forvo",
      "id": "forvo_zh",
      "path": "user_files/zh",
      "display": "Forvo (%s)"
    },
    {
      "type": "forvo",
      "id": "forvo_ko",
      "path": "user_files/ko",
      "display": "Forvo (%s)"
    }
  ]
}

Then in Yomitan, add a Custom URL (JSON) given by http://localhost:5050/?term={term}&reading={reading}&sources=forvo_ko.

@quopquai
Copy link

Thanks ReimeiSky I did what you said,

Screenshot 2025-01-14 at 17 55 54

regenerated, and it looks like the system seems to recognise the the ko folder,

Screenshot 2025-01-14 at 17 28 35

I added the custom url to Yomitan...

but alas, it is still not working for me! :( - I'm lost!

@ReimeiSky
Copy link

Can you join the Yomitan Discord so we can work this out? It's at the top of https://yomitan.wiki/.

@ecsalamanc
Copy link

ecsalamanc commented Jan 14, 2025

How do you get a config.json file? Mine looks like this:

Screenshot 2025-01-14 at 1 52 27 PM

@quopquai
Copy link

quopquai commented Jan 14, 2025

I just copied the "default_config.json" file four items down from the list and renamed it

@quopquai
Copy link

Can you join the Yomitan Discord so we can work this out? It's at the top of https://yomitan.wiki/.

Who do I contact in the Discord? - Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants