From 59eda1f95673d8d318b85e618746aa169cce296f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Vukovi=C4=87?= Date: Sat, 6 Jul 2024 22:15:00 +0200 Subject: [PATCH] [en] fix phrasal verbs with interposed 'it' or 'one' (#1179) --- ext/js/language/en/english-transforms.js | 2 +- test/language/english-transforms.test.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ext/js/language/en/english-transforms.js b/ext/js/language/en/english-transforms.js index 59c4ac9995..96b30e4f5c 100644 --- a/ext/js/language/en/english-transforms.js +++ b/ext/js/language/en/english-transforms.js @@ -59,7 +59,7 @@ const thirdPersonSgPresentSuffixInflections = [ ]; const phrasalVerbParticles = ['aboard', 'about', 'above', 'across', 'ahead', 'alongside', 'apart', 'around', 'aside', 'astray', 'away', 'back', 'before', 'behind', 'below', 'beneath', 'besides', 'between', 'beyond', 'by', 'close', 'down', 'east', 'west', 'north', 'south', 'eastward', 'westward', 'northward', 'southward', 'forward', 'backward', 'backwards', 'forwards', 'home', 'in', 'inside', 'instead', 'near', 'off', 'on', 'opposite', 'out', 'outside', 'over', 'overhead', 'past', 'round', 'since', 'through', 'throughout', 'together', 'under', 'underneath', 'up', 'within', 'without']; -const phrasalVerbPrepositions = ['aback', 'about', 'above', 'across', 'after', 'against', 'ahead', 'along', 'among', 'apart', 'around', 'as', 'aside', 'at', 'away', 'back', 'before', 'behind', 'below', 'between', 'beyond', 'by', 'down', 'even', 'for', 'forth', 'forward', 'from', 'in', 'into', 'it', 'of', 'off', 'on', 'one', 'onto', 'open', 'out', 'over', 'past', 'round', 'through', 'to', 'together', 'toward', 'towards', 'under', 'up', 'upon', 'way', 'with', 'without']; +const phrasalVerbPrepositions = ['aback', 'about', 'above', 'across', 'after', 'against', 'ahead', 'along', 'among', 'apart', 'around', 'as', 'aside', 'at', 'away', 'back', 'before', 'behind', 'below', 'between', 'beyond', 'by', 'down', 'even', 'for', 'forth', 'forward', 'from', 'in', 'into', 'of', 'off', 'on', 'onto', 'open', 'out', 'over', 'past', 'round', 'through', 'to', 'together', 'toward', 'towards', 'under', 'up', 'upon', 'way', 'with', 'without']; const particlesDisjunction = phrasalVerbParticles.join('|'); const phrasalVerbWordSet = new Set([...phrasalVerbParticles, ...phrasalVerbPrepositions]); diff --git a/test/language/english-transforms.test.js b/test/language/english-transforms.test.js index 0336461884..45fb0a62c3 100644 --- a/test/language/english-transforms.test.js +++ b/test/language/english-transforms.test.js @@ -104,6 +104,8 @@ const tests = [ valid: true, tests: [ {term: 'look up', source: 'look something up', rule: 'v_phr', reasons: ['interposed object']}, + {term: 'look up', source: 'look it up', rule: 'v_phr', reasons: ['interposed object']}, + {term: 'look up', source: 'look one up', rule: 'v_phr', reasons: ['interposed object']}, {term: 'look up', source: 'looking up', rule: 'v_phr', reasons: ['ing']}, {term: 'look up', source: 'looked up', rule: 'v_phr', reasons: ['past']}, {term: 'look up', source: 'looks up', rule: 'v_phr', reasons: ['3rd pers. sing. pres']},