Set editing profile index correctly when deleting profile (#1560)

* handle editing profile index correctly when delete profile * lint * simplify index calculation * rename variables * Revert "rename variables" This reverts commit 4d81d24.
yomidevs · Nov 4, 2024 · afd0b67 · afd0b67
1 parent 37ba526
commit afd0b67
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/ext/js/pages/settings/profile-controller.js b/ext/js/pages/settings/profile-controller.js
@@ -259,8 +259,10 @@ export class ProfileController {
         this._updateProfileSelectOptions();
 
         // Update profile index
-        if (settingsProfileIndex === profileIndex) {
-            this._settingsController.profileIndex = profileCurrentNew;
+        if (settingsProfileIndex >= profileIndex) {
+            this._settingsController.profileIndex = settingsProfileIndex - 1;
+        } else {
+            this._settingsController.refreshProfileIndex();
         }
 
         // Modify settings

diff --git a/ext/js/pages/settings/settings-controller.js b/ext/js/pages/settings/settings-controller.js
@@ -67,6 +67,11 @@ export class SettingsController extends EventDispatcher {
         this._setProfileIndex(value, true);
     }
 
+    /** */
+    refreshProfileIndex() {
+        this._setProfileIndex(this._profileIndex, true);
+    }
+
     /** @type {HtmlTemplateCollection} */
     get templates() {
         return this._templates;