Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching profiles causes insane laggs and is basically unusable #1480

Open
AdriGrana opened this issue Oct 12, 2024 · 5 comments
Open

Switching profiles causes insane laggs and is basically unusable #1480

AdriGrana opened this issue Oct 12, 2024 · 5 comments
Labels
area/performance The issue or PR is related to performance kind/bug The issue or PR is regarding a bug

Comments

@AdriGrana
Copy link

Description
When I switch profiles via the dropdown menu on the top left in Yomitans search page it often (95% of the time) causes insane lags and I have to wait up to several minutes until Yomitan is usable again. My whole browser is actualy affected by it as other Extension won't work properly anymore. Are profiles not meant to be switched back and forth a lot?

This is what happens in the service worker once the laggs start happening when I switch profiles:
image

Reproducing it is easy on my machine by just switching profiles and trying to scan something with the hotkey, but I would guess most peopel do not have that issue so there are no clearer instructions I can give to reproduce it (maybe try to switch very quickly back and forth between different profiles and see if everything works immediately). I am also the user who had issue #922 which I could never solve so maybe it has some relation that I am not aware off.

If there is any additional info I can provide that would make finding the issue easier please tell me.

If it's again just an issue on my machine and others don't experience that feel free to close this issue. Though I would appreciate some help.

System
Windows 10
AMD Ryzen 7800X3D
Nvidia RTX4080
32GB RAM 5200MT/s (DDR5)

Browser version
Chrome is up to date
Version 129.0.6668.101 (Official Build) (64-bit)

Yomitan version
Extension version: Yomitan 24.9.23.0

Exported settings file
yomitan-settings-2024-10-12-15-28-35.json

@AdriGrana AdriGrana added the kind/bug The issue or PR is regarding a bug label Oct 12, 2024
@horstschumacher
Copy link

It's not quite as severe for me but I've had the same thing happen to me many times. It seems to happen more if the yomitan search page is open (I feel like having searched something as opposed to the site being empty also matters) and a LOT more if the settings page is open.

@shiki-tm
Copy link

shiki-tm commented Oct 13, 2024

I've also had the same issue for at least 2 or 3 months on both my PC and phone. I didn't say anything because I thought they knew. The best way to describe it is just insane lag. Yomitan becomes unusable and my browser gets laggy. Maybe the fonts between the profiles is switched but the dictionaries and everything else stays frozen, like it switched settings halfway. Anywhere from 30 seconds to even a few minutes sometimes. I'm also curious why switching profiles makes it so bad.

@AdriGrana
Copy link
Author

So basically the devs don't care or will this ever be addressed? My RAM gets filled too when that happens, seems like Yomitan has a severe memory leak issue (in general) but especially when I switch profiles.

@Kuuuube
Copy link
Member

Kuuuube commented Nov 12, 2024

It's very difficult to track down issues like this. Most users do not have this issue. There have been a few people who have looked into this but so far no fixes have been put forward. There's also #1487 which has gotten a lot of work and could possibly help.

Just because you see this issue doesn't get worked on and other do, doesn't mean the devs don't care about this issue. But if you're wondering if this will be fixed soon, it probably won't. And even if it is fixed it's hard to confirm that is has been fixed.

Reporting these issues is still always appreciated even if we don't get to them quickly.

@AdriGrana
Copy link
Author

@Kuuuube I am actually not expecting the devs to work on this exact issue quickly (or at all) afterall it's a free open source project so it's not like I have any expectations, I just think it would at least have been nice to get a respons after I opened the issue but it never came (until now which I am really thankful for!!).

Honestly it's a bit frustrating, is there anyone I can pay that debugs the code on my machine? I don't think a memory leak is a small issue either (it fills my RAM with 10+GB until it's full) and hearing that it probably won't be fixed sounds like a huge red flag to me.

I don't think it's "few" people either, at least others in this thread alone have mentioned having this issue too and I think #922 is related and there are also people with simmilar concerns. Also in other communities when the question of Yomitan vs 10ten comes up, many users always mention the performance/crashing issues of Yomitan as negative compared to 10ten so it's definitely a known issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance The issue or PR is related to performance kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

4 participants