Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsed Dictionaries Function doesn't work #1658

Closed
jamesmaa opened this issue Dec 12, 2024 · 0 comments · Fixed by #1660
Closed

Collapsed Dictionaries Function doesn't work #1658

jamesmaa opened this issue Dec 12, 2024 · 0 comments · Fixed by #1660
Labels
gоοd fіrst іssսe The issue is a good starting point for first-time contributors kind/bug The issue or PR is regarding a bug regression This issue or PR is related to a regression

Comments

@jamesmaa
Copy link
Collaborator

jamesmaa commented Dec 12, 2024 •
edited
Loading

Broken by #1645

image

We still need the this._dictionaries.clear() call to avoid memory leaks but somehow the this._dictionaries state is not managed correctly w.r.t. the UI.

More context: https://discord.com/channels/1171709317343346789/1316669066324475914
@jamesmaa jamesmaa added kind/bug The issue or PR is regarding a bug gоοd fіrst іssսe The issue is a good starting point for first-time contributors labels Dec 12, 2024
@Kuuuube Kuuuube added the regression This issue or PR is related to a regression label Dec 13, 2024
@khaitruong922 khaitruong922 mentioned this issue Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gоοd fіrst іssսe The issue is a good starting point for first-time contributors kind/bug The issue or PR is regarding a bug regression This issue or PR is related to a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix collapse dictionary not working khaitruong922/yomitan
2 participants
@jamesmaa @Kuuuube