Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions of the word forms #572

Closed
ganqqwerty opened this issue Jan 24, 2024 · 3 comments · Fixed by #1000
Closed

Descriptions of the word forms #572

ganqqwerty opened this issue Jan 24, 2024 · 3 comments · Fixed by #1000
Assignees
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@ganqqwerty
Copy link

When the word is not in its dictionary form, yomitan shows a form indicator (for example -tai for 食べたい). These form indicators can be made more comprehensible. One way to do it is to have a short description of each word form and show this description on hover.

For 食べたい example:

  • the user hovers on the -tai indicator
  • yomitan shows a tooltip "wants to do form of the verb"
    CleanShot 2024-01-24 at 14 53 21@2x
@ganqqwerty ganqqwerty added the kind/enhancement The issue or PR is a new feature or request label Jan 24, 2024
@ganqqwerty
Copy link
Author

Related issue: #564

@toasted-nutbread
Copy link

toasted-nutbread commented Jan 25, 2024

I completely agree with this. This ties back into the comment I've made a few times about "this format needs to be made more generalized." Additionally, dictionaries should support providing custom inflection maps, which has its own associated set of challenges, and the internal inflection map should support being disabled.

Localization is another thing to consider with this. For example providing descriptions for Spanish-speaking people who may be learning Japanese is something that could be done, but is not presently easy.

@ganqqwerty
Copy link
Author

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants