Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change messaging to dictionary size #1652

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Change messaging to dictionary size #1652

merged 2 commits into from
Dec 10, 2024

Conversation

jamesmaa
Copy link
Collaborator

Naming is better

@jamesmaa jamesmaa requested a review from a team as a code owner December 10, 2024 18:28
Kuuuube
Kuuuube reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one under _createFrequencyGroup needs to check whether it is kanji or not and set the label accordingly. It is used for both kanji and terms on firefox.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Dec 10, 2024
@jamesmaa jamesmaa enabled auto-merge December 10, 2024 18:45
@jamesmaa jamesmaa added this pull request to the merge queue Dec 10, 2024
Merged via the queue into yomidevs:master with commit 2f609eb Dec 10, 2024
11 checks passed
@jamesmaa jamesmaa deleted the rename-freq-count branch December 10, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuuuube Kuuuube Kuuuube approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmaa @Kuuuube