Fail to cut and paste folder inside itself #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for superfile canceled.
|
lazysegtree
reviewed
Feb 22, 2025
before, this would fail only when cuting and pasting a directory, now the file path is checked before any pasting operation (copy, cut, etc)
Forgot about the other types of pasting. Now it checks for the path before performing any type in elementPaste. Still missing the tests cases thought. Never implemented a test in this project, gonna look into it. |
|
@GRFreire When you are done, please ping me once. I would like to review the changes once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails the moveElement operation when trying to move something into itself.
For now, the only thing it does is failing the operation, but does not open a modal for warning. It leaves the process cancellation (UI) to the pasteItem handler. If an modal is wanted, I can try to add to this PR, otherwise, it can be left like this - only failing but no communication to the user - with the issue solved.
Fixes #570