From f4f38d28f11a7c4a4bb29d77408e2cdaceb8f3c1 Mon Sep 17 00:00:00 2001
From: Daniel Norberg <dano@modal.com>
Date: Mon, 23 Dec 2024 22:17:23 +0900
Subject: [PATCH 1/2] clippy --all-targets

---
 .github/workflows/ci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index cf68709c..47131eae 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -32,7 +32,7 @@ jobs:
       - name: format check
         run: cargo fmt --all -- --check
       - name: clippy check
-        run: cargo clippy -- -D warnings
+        run: cargo clippy --all-targets -- -D warnings
   check-deps:
     name: check-deps
     runs-on: ubuntu-latest

From 655e6ecaefc10a96a88df25b71aac4a8bd7b7bbc Mon Sep 17 00:00:00 2001
From: Daniel Norberg <dano@modal.com>
Date: Mon, 23 Dec 2024 22:30:42 +0900
Subject: [PATCH 2/2] silence benign lint errors in test code

---
 spanner/tests/change_stream_test.rs | 4 ++++
 spanner/tests/common.rs             | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/spanner/tests/change_stream_test.rs b/spanner/tests/change_stream_test.rs
index 44c07b96..485f0682 100644
--- a/spanner/tests/change_stream_test.rs
+++ b/spanner/tests/change_stream_test.rs
@@ -29,6 +29,7 @@ fn init() {
     let _ = tracing_subscriber::fmt().with_env_filter(filter).try_init();
 }
 
+#[allow(dead_code)]
 #[derive(Debug)]
 struct ChangeRecord {
     pub data_change_record: Vec<DataChangeRecord>,
@@ -44,6 +45,7 @@ impl TryFromStruct for ChangeRecord {
     }
 }
 
+#[allow(dead_code)]
 #[derive(Debug)]
 struct ChildPartitionsRecord {
     pub start_timestamp: OffsetDateTime,
@@ -61,6 +63,7 @@ impl TryFromStruct for ChildPartitionsRecord {
     }
 }
 
+#[allow(dead_code)]
 #[derive(Debug)]
 struct ChildPartition {
     pub token: String,
@@ -76,6 +79,7 @@ impl TryFromStruct for ChildPartition {
     }
 }
 
+#[allow(dead_code)]
 #[derive(Debug)]
 struct DataChangeRecord {
     pub commit_timestamp: OffsetDateTime,
diff --git a/spanner/tests/common.rs b/spanner/tests/common.rs
index 2c90f566..3ad6ba6d 100644
--- a/spanner/tests/common.rs
+++ b/spanner/tests/common.rs
@@ -18,6 +18,7 @@ use google_cloud_spanner::bigdecimal::BigDecimal;
 
 pub const DATABASE: &str = "projects/local-project/instances/test-instance/databases/local-database";
 
+#[allow(dead_code)]
 pub struct UserCharacter {
     pub user_id: String,
     pub character_id: i64,
@@ -36,6 +37,7 @@ impl TryFromStruct for UserCharacter {
     }
 }
 
+#[allow(dead_code)]
 pub struct UserItem {
     pub user_id: String,
     pub item_id: i64,
@@ -54,6 +56,7 @@ impl TryFromStruct for UserItem {
     }
 }
 
+#[allow(dead_code)]
 pub struct UserItemWithHistory {
     pub user_id: String,
     pub item_id: i64,
@@ -74,6 +77,7 @@ impl TryFromStruct for UserItemWithHistory {
     }
 }
 
+#[allow(dead_code)]
 pub struct UserItemHistory {
     pub user_id: String,
     pub item_id: i64,