Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve typography tokens #3

Merged
merged 4 commits into from
Jan 3, 2025
Merged

fix: improve typography tokens #3

merged 4 commits into from
Jan 3, 2025

Conversation

eihabkhan
Copy link
Member

@eihabkhan eihabkhan commented Jan 3, 2025 •
edited
Loading

Ticket

https://youcanshop.atlassian.net/browse/UI-508

QA Steps

  • cd into celeste-tokens
  • run pnpm build
  • check tokens.css, you should look for a couple of things
    • The typography vars are no longer prefixed with --typo-
    • Size words like X Large, Large, Medium, Small, X Small, and 2X Small are replaced by xl, lg, md, sm, xs, and 2xs respectively

@eihabkhan eihabkhan self-assigned this Jan 3, 2025
@azuradara azuradara changed the title UI-508: fix: improve typography tokens fix: improve typography tokens Jan 3, 2025
@eihabkhan eihabkhan merged commit c5704e6 into main Jan 3, 2025
2 checks passed
@eihabkhan eihabkhan deleted the UI-508 branch January 3, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azuradara azuradara azuradara approved these changes

Assignees

@eihabkhan eihabkhan

Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan @azuradara