-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to spawn processes as siblings #3012
Conversation
Signed-off-by: Jorge Prendes <[email protected]>
Is there a good way to test this behavior? |
I think we can create an integration type of test, and check the ppid of the init process. I'll give that a go later today. |
Signed-off-by: Jorge Prendes <[email protected]>
My apologies. I saw that the builder was a pub struct, and we were updating the fields, so it was breaking. But we actually don't expose the fields, only the builder methods, so this should not be a breaking change. Have removed the label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍
Maybe wait for utam0k 's reply, but approving from my side.
Thanks! |
This PR adds the option to spawn processes as siblings of the calling processes instead of spawning them as children.
See #3011 for more context.