Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handy Iconography 적용 #120

Closed
13 tasks done
nijuy opened this issue Jul 9, 2024 · 0 comments · Fixed by #121
Closed
13 tasks done

feat: Handy Iconography 적용 #120

nijuy opened this issue Jul 9, 2024 · 0 comments · Fixed by #121
Assignees
@nijuy
Labels
feat

Comments

@nijuy
Copy link
Collaborator

nijuy commented Jul 9, 2024 •
edited
Loading

ISSUE ✅ : Handy Iconography 적용

📖 Summary

이번 Handy에서 제안된 내용대로 아이콘 컴포넌트를 수정합니다

Todo

  • Figma svg export
  • svg 파일명 수정
  • 기존 파일 삭제
    • iconAsset/*
    • component/* (except YDSWrapper - 기존 아이콘을 쓰는 컴포넌트들이 있어서)
    • icons/generated/*
    • IconContext.Provider
  • IconProps 타입 수정
    • 아이콘 크기 제한 (7종류)
    • mirrored 필드 삭제
  • convert-icon
  • 검토
  • 문서 수정
@nijuy nijuy added the feat label Jul 9, 2024
@nijuy nijuy self-assigned this Jul 9, 2024
@nijuy nijuy mentioned this issue Jul 9, 2024
Merged
3 tasks
@nijuy nijuy linked a pull request Jul 10, 2024 that will close this issue
feat: handy icon 적용 #121
Merged
3 tasks
fecapark added a commit that referenced this issue Jul 11, 2024
@fecapark
Merge pull request #121 from yourssu/feat/#120-handy-icon
9d2a292 
feat: handy icon 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijuy nijuy

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handy icon 적용 yourssu/Handy-React
1 participant
@nijuy