Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: color 속성이 icon에 적용되지 않는 문제 #133

Closed
nijuy opened this issue Jul 22, 2024 · 0 comments · Fixed by #134
Closed

bug: color 속성이 icon에 적용되지 않는 문제 #133

nijuy opened this issue Jul 22, 2024 · 0 comments · Fixed by #134
Assignees
@nijuy
Labels
bug Something isn't working fix

Comments

@nijuy
Copy link
Collaborator

nijuy commented Jul 22, 2024

ISSUE ✅ : icon color

📖 Summary

컴포넌트에 color를 지정하면 컴포넌트 내부 아이콘에도 적용이 되어야 하는데, 그게 안됨

Error Script

icon.base.tsx에서 currentColor가 아니라 current로 잘못 써서 발생하는 문제

Photo

image

BoxButton에 color: ${({ theme }) => theme.semantic.color.textBasicWhite}; 가 적용된 상탠데
아이콘에는 해당 색상 적용이 안된 걸 확인 가능
@nijuy nijuy added bug Something isn't working fix labels Jul 22, 2024
@nijuy nijuy self-assigned this Jul 22, 2024
@nijuy nijuy mentioned this issue Jul 22, 2024
Merged
1 task
@nijuy nijuy linked a pull request Jul 22, 2024 that will close this issue
fix: color 속성이 icon에 적용되지 않는 문제 #134
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijuy nijuy

Labels
bug Something isn't working fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: color 속성이 icon에 적용되지 않는 문제 yourssu/Handy-React
1 participant
@nijuy