Renamed display ad leftovers (test descriptions, swagger) (forem#20007)

Author: lightalloy

spec/factories/articles.rb

@@ -34,7 +34,7 @@
 
     experience_level_rating { rand(4..6) }
     # The tags property in the markdown is a bit of a hack, and this entire factory needs refactoring.
-    # In the Tagglable spec we want to extract some common scopes from the article and display ad
+    # In the Tagglable spec we want to extract some common scopes from the article and billboard
     # models and test them, hence we want to pass through the tag_list property.
     # However, the body_markdown caters for the way that we associate tags for the v1 editor.
     # Hence, in this test we default to the transient with_tags being set to true, but if we pass a tag_list through

spec/lib/data_update_scripts/generate_display_ad_names_spec.rb

@@ -5,15 +5,15 @@
 
 describe DataUpdateScripts::GenerateDisplayAdNames do
   context "when there is no name for a billboard" do
-    it "generates a name for an existing Display Ad" do
+    it "generates a name for an existing Billboard" do
       billboard = create(:billboard, name: nil)
 
       described_class.new.run
       expect(billboard.reload.name).to eq("Billboard #{billboard.id}")
     end
   end
 
-  context "when there is a name for the Display Ad" do
+  context "when there is a name for the Billboard" do
     it "does not change the name" do
       billboard = create(:billboard, name: "Test")
 

spec/requests/admin/billboards_spec.rb

@@ -99,7 +99,7 @@
     describe "DELETE /admin/billboards/:id" do
       let!(:billboard) { create(:billboard) }
 
-      it "deletes the Display Ad" do
+      it "deletes the Billboard" do
         expect do
           delete admin_billboard_path(billboard.id)
         end.to change { Billboard.all.count }.by(-1)
@@ -147,7 +147,7 @@
     describe "DELETE /admin/billboards/:id" do
       let!(:billboard) { create(:billboard) }
 
-      it "deletes the Display Ad" do
+      it "deletes the Billboard" do
         expect do
           delete admin_billboard_path(billboard.id)
         end.to change { Billboard.all.count }.by(-1)

spec/requests/admin/html_variants_spec.rb

@@ -66,7 +66,7 @@
     describe "DELETE /admin/customization/html_variants/:id" do
       let!(:html_variant) { create(:html_variant) }
 
-      it "deletes the Display Ad" do
+      it "deletes the Billboard" do
         expect do
           delete admin_html_variant_path(html_variant.id)
         end.to change { HtmlVariant.all.count }.by(-1)
@@ -110,7 +110,7 @@
     describe "DELETE /admin/customization/html_variants/:id" do
       let!(:html_variant) { create(:html_variant) }
 
-      it "deletes the Display Ad" do
+      it "deletes the Billboard" do
         expect do
           delete admin_html_variant_path(html_variant.id)
         end.to change { HtmlVariant.all.count }.by(-1)

spec/swagger_helper.rb

@@ -399,10 +399,10 @@
             }
           },
           Billboard: {
-            description: "A Display Ad, aka Billboard, aka Widget",
+            description: "Billboard, aka Widget, ex. Display Ad",
             type: :object,
             properties: {
-              id: { type: :integer, description: "The ID of the Display Ad" },
+              id: { type: :integer, description: "The ID of the Billboard" },
               name: { type: :string, description: "For internal use, helps distinguish ads from one another" },
               body_markdown: { type: :string, description: "The text (in markdown) of the ad (required)" },
               approved: { type: :boolean, description: "Ad must be both published and approved to be in rotation" },