Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare python 3.13 support #66

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Declare python 3.13 support #66

wants to merge 4 commits into from

Conversation

youtux
Copy link
Owner

@youtux youtux commented Sep 30, 2024

Summary by Sourcery

Add support for Python 3.13 in the CI workflow by updating the configuration to include testing for this version.

CI:

  • Add Python 3.13 to the CI workflow to ensure compatibility and testing with the latest Python version.

Copy link

sourcery-ai bot commented Sep 30, 2024

Reviewer's Guide by Sourcery

This pull request updates the GitHub Actions workflow to include support for Python 3.13 and changes the Python 3.12 version from "3.12-dev" to "3.12".

No sequence diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add support for Python 3.13 in the CI workflow
  • Add a new matrix entry for Python 3.13
  • Set the toxfactor for Python 3.13 to 'py313'
  • Set ignore-typecheck-outcome to false for Python 3.13
.github/workflows/main.yml
Update Python 3.12 version specification
  • Change Python 3.12 version from '3.12-dev' to '3.12'
.github/workflows/main.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @youtux - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider holding off on adding Python 3.13 support until it's closer to release or at least in beta stage. Testing against such an early version might lead to unreliable CI results.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant